Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_all.py --save gets stuck #2481

Closed
emilk opened this issue Jun 20, 2023 · 1 comment · Fixed by #2519
Closed

run_all.py --save gets stuck #2481

emilk opened this issue Jun 20, 2023 · 1 comment · Fixed by #2519
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI)

Comments

@emilk
Copy link
Member

emilk commented Jun 20, 2023

./scripts/run_all.py --save gets stuck on car/main.py.

I added some log statements, and car/main.py finished its main, and rerun_shutdown also finishes, but process.wait in run_all.py never returns
@emilk emilk added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) labels Jun 20, 2023
@emilk emilk assigned emilk and Wumpf and unassigned emilk Jun 20, 2023
@emilk
Copy link
Member Author

emilk commented Jun 20, 2023

So @Wumpf discovered that run_all actually has very confusing printouts that make it seem like it gets stuck on car, but is actually stuck on the example after it.

@Wumpf Wumpf mentioned this issue Jun 26, 2023
Merged
1 task
Wumpf added a commit that referenced this issue Jun 27, 2023
@Wumpf
run_all.py script fixes (#2519)
b3b4277 
* no longer getting stuck on face tracking
* fix failing saving on examples that can't do so
* fix not showing what example is run before running it

Fixes #2481

After these changes I can now run `python ./scripts/run_all.py --save`
on my machine successfully.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2519

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/728de20/docs
Examples preview: https://rerun.io/preview/728de20/examples
<!-- pr-link-docs:end -->
emilk pushed a commit that referenced this issue Jun 29, 2023
@Wumpf @emilk
run_all.py script fixes (#2519)
0304410 
* no longer getting stuck on face tracking
* fix failing saving on examples that can't do so
* fix not showing what example is run before running it

Fixes #2481

After these changes I can now run `python ./scripts/run_all.py --save`
on my machine successfully.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2519

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/728de20/docs
Examples preview: https://rerun.io/preview/728de20/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run_all.py script fixes rerun-io/rerun
2 participants
@emilk @Wumpf