Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate index.html page variants #2428

Closed
jleibs opened this issue Jun 14, 2023 · 0 comments · Fixed by #4720
Closed

Consolidate index.html page variants #2428

jleibs opened this issue Jun 14, 2023 · 0 comments · Fixed by #4720
Labels
😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality 🕸️ web regarding running the viewer in a browser

Comments

@jleibs
Copy link
Member

jleibs commented Jun 14, 2023 •
edited
Loading

We currently have at least 3 different variants of index.html:

  • web_viewer/index.html is the version that gets served on app.rerun.io
  • web_viewer/index_bundled is the version that gets served directly from the viewer
  • scripts/demo_assets/templates/example.hml is the version that gets served on the demo page

Making functional changes to the web-app that touch the index.html involves touching all 3 of these files while tracking slight modifications.

See #2421 for motivation.
@jleibs jleibs added 🕸️ web regarding running the viewer in a browser 😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality labels Jun 14, 2023
@jprochazk jprochazk mentioned this issue Jan 8, 2024
Merged
4 tasks
jprochazk added a commit that referenced this issue Jan 9, 2024
@jprochazk
Unify web_viewer/index.html and index_bundled.html (#4720)
a997398 
### What

It turns out this was already mostly done. The only change needed was
removing the analytics script and adding it via JS when we are served on
`app.rerun.io`.

Fixes #2156
Fixes #2428

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4720/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4720/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4720/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4720)
- [Docs
preview](https://rerun.io/preview/9d10741f8a8a21de05f24fca7f82ebb130d2d063/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/9d10741f8a8a21de05f24fca7f82ebb130d2d063/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify web_viewer/index.html and index_bundled.html rerun-io/rerun
1 participant
@jleibs