Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Space View class display name and Space View identifier #2336

Closed
Wumpf opened this issue Jun 8, 2023 · 0 comments · Fixed by #4393
Closed

Split Space View class display name and Space View identifier #2336

Wumpf opened this issue Jun 8, 2023 · 0 comments · Fixed by #4393
Labels
🟦 blueprint The data that defines our UI 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Jun 8, 2023

Having the user-visible name also be the unique identifier isn't great. If one wants to rename the space view class we would need to also update the blueprint code. Not to speak of localization.

I think it would make sense with something like ext.color_coordinates as the unique identifier and "Color Coordinates" as the name, and then have rerun.spatial2d etc for the built-in space view classes

Originally posted by @emilk in #2328 (comment)
@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🏎️ Quick Issue Can be fixed in a few hours or less 🟦 blueprint The data that defines our UI labels Jun 8, 2023
@Wumpf Wumpf mentioned this issue Jun 8, 2023
Merged
2 tasks
@Wumpf Wumpf mentioned this issue Nov 29, 2023
Merged
4 tasks
@abey79 abey79 mentioned this issue Nov 30, 2023
Merged
4 tasks
abey79 added a commit that referenced this issue Nov 30, 2023
@abey79
Add ui_name() to SpaceViewClass so space views may provide a user…
ee83418 
…-facing name (#4393)

### What

With this change, the user-facing string for a space view class can be
changed without breaking blueprint files. This PR also reverts the
change from "TextLog" to "Text Log" to avoid breaking last release's
blueprint (*)

* Fixes #2336 

(*) Unknown space view class name do not trigger a blueprint rebuild,
but instead yield an "unknown space view" in the UI, which is Bad UX™️

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4393) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4393)
- [Docs
preview](https://rerun.io/preview/3b3229f5e6a053574a2e94e1f5f63907da8d703c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3b3229f5e6a053574a2e94e1f5f63907da8d703c/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add display_name() to SpaceViewClass so space views may provide a user-facing name rerun-io/rerun
1 participant
@Wumpf