Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust API does not expose serve #2232

Closed
Tracked by #2779
Wumpf opened this issue May 26, 2023 · 0 comments · Fixed by #2815
Closed
Tracked by #2779

Rust API does not expose serve #2232

Wumpf opened this issue May 26, 2023 · 0 comments · Fixed by #2815
Assignees
@teh-cmc
Labels
🦟 regression A thing that used to work in an earlier release 🦀 Rust API Rust logging API 🕸️ web regarding running the viewer in a browser
Milestone
0.8

Comments

@Wumpf
Copy link
Member

Wumpf commented May 26, 2023

I.e. it is not possible right now to serve a web viewer from the rust SDK.
This fell victim to refactor around the removal of sessions and we need to bring it back.

See also doc changes rerun-io/rerun-docs#75
@Wumpf Wumpf added 🕸️ web regarding running the viewer in a browser 🦀 Rust API Rust logging API 🦟 regression A thing that used to work in an earlier release labels May 26, 2023
@jleibs jleibs mentioned this issue Jul 21, 2023
Closed
11 tasks
@teh-cmc teh-cmc mentioned this issue Jul 25, 2023
Merged
3 tasks
@abey79 abey79 added this to the 0.8 milestone Jul 25, 2023
Wumpf added a commit that referenced this issue Jul 26, 2023
@teh-cmc @Wumpf
Add support for RecordingStream::serve (#2815)
20a6179 
```rust
let rec_stream = RecordingStreamBuilder::new("minimal_serve_rs").serve(
    "0.0.0.0",
    Default::default(),
    Default::default(),
    true,
)?;
```

Try it with the new `minimal_serve` example:
```
$ cargo r -p minimal_serve
```

Fixes #2232

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2815) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2815)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Frecording_stream_serve/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Frecording_stream_serve/examples)

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🦟 regression A thing that used to work in an earlier release 🦀 Rust API Rust logging API 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Add support for RecordingStream::serve rerun-io/rerun
3 participants
@Wumpf @teh-cmc @abey79