Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected timeline heuristic is unstable #2186

Closed
teh-cmc opened this issue May 23, 2023 · 2 comments · Fixed by #2986
Closed

Selected timeline heuristic is unstable #2186

teh-cmc opened this issue May 23, 2023 · 2 comments · Fixed by #2986
Assignees
@Wumpf
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working ui concerns graphical user interface user-request This is a pressing issue for one of our users
Milestone
0.8.1

Comments

@teh-cmc
Copy link
Member

teh-cmc commented May 23, 2023

Try it yourself by running examples/python/text_logging a bunch of times: sometimes log_time wins, sometimes frame_nr wins, depending on the speed of ingestion.
@teh-cmc teh-cmc added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use labels May 23, 2023
@jleibs jleibs added the 🪳 bug Something isn't working label Jul 27, 2023
@jleibs
Copy link
Member

jleibs commented Jul 27, 2023

I've observed this leading to confusion on multiple occasions -- bumping priority to high so that it actually gets fixed.

Also marking as bug as this is a departure from our expected behavior of always defaulting to user-provided timeline.

The major challenge with implementing this is that there is a race-condition when we start laying out views where it's possible that the only data we have received is the SetStoreInfo message and thus have no timelines to base our decision off of. Similar to other properties we probably need some form of an EditableAutoValue here.

@Wumpf Wumpf added the user-request This is a pressing issue for one of our users label Jul 28, 2023
@nikolausWest
Copy link
Member

Solution:

  • make it an EditableAutoValue
  • auto = first user timeline

@nikolausWest nikolausWest added this to the 0.9 milestone Aug 7, 2023
@emilk emilk modified the milestones: 0.9, 0.8.1 Aug 8, 2023
Wumpf added a commit that referenced this issue Aug 15, 2023
@Wumpf
Automatically select user timeline if no timeline was explicitly sele…
9cd470e 
…cted yet

Fixes #2186
@Wumpf Wumpf mentioned this issue Aug 15, 2023
Merged
3 tasks
@Wumpf Wumpf self-assigned this Aug 15, 2023
Wumpf added a commit that referenced this issue Aug 16, 2023
@Wumpf
Automatically select user timeline if no timeline was explicitly sele…
d0de66c 
…cted yet (#2986)

* Fixes #2186

Slight deviation from the desired behavior from the ticket: We'll always
select the user timeline which is _alphabetically first_. I deem this
good enough though and an improvement in any case!

Going back the the "auto select" state is not possible explicitely, but
will happen if for whatever reason no user timeline is available
anymore.

Tested as seen in the video and then confirmed separately the described
alphabetic behavior



https://github.com/rerun-io/rerun/assets/1220815/0d3303d7-7b19-4854-993d-0523b3e35cbb



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2986) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2986)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-timeline-auto-select/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-timeline-auto-select/examples)
emilk pushed a commit that referenced this issue Aug 17, 2023
@Wumpf @emilk
Automatically select user timeline if no timeline was explicitly sele…
c852e2d 
…cted yet (#2986)

* Fixes #2186

Slight deviation from the desired behavior from the ticket: We'll always
select the user timeline which is _alphabetically first_. I deem this
good enough though and an improvement in any case!

Going back the the "auto select" state is not possible explicitely, but
will happen if for whatever reason no user timeline is available
anymore.

Tested as seen in the video and then confirmed separately the described
alphabetic behavior



https://github.com/rerun-io/rerun/assets/1220815/0d3303d7-7b19-4854-993d-0523b3e35cbb



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2986) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2986)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-timeline-auto-select/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-timeline-auto-select/examples)
emilk pushed a commit that referenced this issue Aug 17, 2023
@Wumpf @emilk
Automatically select user timeline if no timeline was explicitly sele…
751936e 
…cted yet (#2986)

* Fixes #2186

Slight deviation from the desired behavior from the ticket: We'll always
select the user timeline which is _alphabetically first_. I deem this
good enough though and an improvement in any case!

Going back the the "auto select" state is not possible explicitely, but
will happen if for whatever reason no user timeline is available
anymore.

Tested as seen in the video and then confirmed separately the described
alphabetic behavior



https://github.com/rerun-io/rerun/assets/1220815/0d3303d7-7b19-4854-993d-0523b3e35cbb



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2986) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2986)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-timeline-auto-select/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-timeline-auto-select/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working ui concerns graphical user interface user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
0.8.1
Development

Successfully merging a pull request may close this issue.

Automatically select user timeline if no timeline was explicitly selected yet rerun-io/rerun
5 participants
@emilk @Wumpf @nikolausWest @teh-cmc @jleibs