Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] changing a shader isn't picked up correctly and compiles too many things #2185

Closed
Wumpf opened this issue May 23, 2023 · 0 comments · Fixed by #4374
Closed

[web] changing a shader isn't picked up correctly and compiles too many things #2185

Wumpf opened this issue May 23, 2023 · 0 comments · Fixed by #4374
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) 🕸️ web regarding running the viewer in a browser

Comments

@Wumpf
Copy link
Member

Wumpf commented May 23, 2023

No description provided.

@Wumpf Wumpf added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) 🕸️ web regarding running the viewer in a browser labels May 23, 2023
Wumpf added a commit that referenced this issue Nov 28, 2023
### What

* Fixes #2185
* the "and compiles too many things" seems to have resolved itself, at
least I can't see how that's the case

Turned out we accidentally only tracked them for re_viewer itself

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4374) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4374)
- [Docs
preview](https://rerun.io/preview/359cf68a0aed5ea7a47dba4dd4927b10a4773b2c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/359cf68a0aed5ea7a47dba4dd4927b10a4773b2c/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
teh-cmc pushed a commit that referenced this issue Nov 30, 2023
### What

* Fixes #2185
* the "and compiles too many things" seems to have resolved itself, at
least I can't see how that's the case

Turned out we accidentally only tracked them for re_viewer itself

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4374) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4374)
- [Docs
preview](https://rerun.io/preview/359cf68a0aed5ea7a47dba4dd4927b10a4773b2c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/359cf68a0aed5ea7a47dba4dd4927b10a4773b2c/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant