Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for planes and rays #2179

Open
roym899 opened this issue May 22, 2023 · 2 comments
Open

Add support for planes and rays #2179

roym899 opened this issue May 22, 2023 · 2 comments
Labels
enhancement New feature or request 🔺 re_renderer affects re_renderer itself

Comments

@roym899
Copy link
Collaborator

roym899 commented May 22, 2023

Is your feature request related to a problem? Please describe.
Sometimes it could be useful to log a 3D plane or lines that extend to infinity. A closely related feature would be primitives that extend to infinity only in some directions (e.g., rays).
An example would be to visualize the epipolar plane of two images.

Describe the solution you'd like
Either separate functions such as log.plane / log.ray / log.line. Support for np.inf (or similar) for existing functions might be reasonable in some cases (e.g. width and height for rectangles).

Describe alternatives you've considered
Simply logging a very long line behaves reasonably well already, but isn't as nice. Logging a plane seems only possible indirectly through log_rect + log_rigid3 right now.

Additional context
Some loosely related issues: #1361, #1531

@roym899 roym899 added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels May 22, 2023
@emilk
Copy link
Member

emilk commented May 22, 2023

Logging planes and rays seems reasonable. Infinite lines could be supported with Plücker Coordinates, though I have a hard time comping up with an example for that

@emilk emilk changed the title Logging (partially) infinite primitives Add support for planes and rays May 22, 2023
@roym899
Copy link
Collaborator Author

roym899 commented May 22, 2023

I agree, there don't seem to be too many use cases for lines, but, for example, a grid or axes could be constructed with those or the intersection of two planes could be highlighted.

@emilk emilk added 🔺 re_renderer affects re_renderer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

No branches or pull requests

2 participants