Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to make Blueprint ergonomic code-wise in the Viewer #2142

Open
emilk opened this issue May 16, 2023 · 2 comments
Open

Plan to make Blueprint ergonomic code-wise in the Viewer #2142

emilk opened this issue May 16, 2023 · 2 comments
Labels
🟦 blueprint The data that defines our UI 💬 discussion enhancement New feature or request

Comments

@emilk
Copy link
Member

emilk commented May 16, 2023

Starting in #2010 we will load the blueprint store from the data store each frame, then write it back. This has many sharp edges:

  • Things that are #[serde(skip)] will be forgotten between frames
  • We need to special-implement PartialEq for some thing due to #[serde(skip)]
  • For each new element in the blueprint we need to write code to:
    • Create a new component for it OR add it to an existing struct and change its arrow type in the "mandatory" doc-test
    • Load it from the store
    • Diff it
    • Write it to the store
    • Write a Python interface for it

This will very quickly collapse under its own weight unless we come up with a better plan

Related:

@emilk emilk added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team 💬 discussion and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels May 16, 2023
@emilk emilk added the 🟦 blueprint The data that defines our UI label May 16, 2023
@emilk
Copy link
Member Author

emilk commented May 26, 2023

We have a plan: code-gen from Flatbuffers IDL. Generate Python and Rust SDKs including the arrow conversions.

We also have #2188

@emilk emilk closed this as completed May 26, 2023
@jleibs jleibs reopened this Aug 1, 2023
@jleibs
Copy link
Member

jleibs commented Aug 1, 2023

Re-opening this until we have line-of-sight on the code-gen flatbuffers IDL actually solving the described painpoints.

@jleibs jleibs added this to the Blueprint from code milestone Aug 25, 2023
@emilk emilk changed the title Make a plan for how to make Blueprint ergonomic Plan to make Blueprint ergonomic code-wise in the Viewer Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 💬 discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants