Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-blueprint state out of the blueprint #2130

Closed
jleibs opened this issue May 16, 2023 · 1 comment
Closed

Move non-blueprint state out of the blueprint #2130

jleibs opened this issue May 16, 2023 · 1 comment
Labels
🟦 blueprint The data that defines our UI

Comments

@jleibs
Copy link
Member

jleibs commented May 16, 2023

As of #2010 the entirety of the blueprint is serialized and then reloaded on every frame. This means that anything marked serde(skip) ends up being reset on every frame. This is related to some rendering helper state, some of the hover selection logic pieces, etc. This behavior complicates the logic of saving/restoring blueprint and clouds the understanding what things are for configuration vs what things are for operation.

All of this needs to move to a different runtime-persistent storage which is used in conjunction with the blueprint to drive the layout and behavior of the views.

@emilk
Copy link
Member

emilk commented May 16, 2023

@emilk emilk added the 🟦 blueprint The data that defines our UI label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI
Projects
None yet
Development

No branches or pull requests

3 participants