Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to hide or move legend in a plot #2049

Closed
Wumpf opened this issue May 4, 2023 · 1 comment · Fixed by #4365
Closed

Make it possible to hide or move legend in a plot #2049

Wumpf opened this issue May 4, 2023 · 1 comment · Fixed by #4365
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself ui concerns graphical user interface user-request This is a pressing issue for one of our users

Comments

@Wumpf
Copy link
Member

Wumpf commented May 4, 2023

several users say it is in the way of their data
should for starters expose position (corners?) and a way to hide it

Should also consider to do what we do in the tensor view and show it only on hover (as an option and/or the default?)
@Wumpf Wumpf added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use labels May 4, 2023
@PeterMitrano
Copy link

Here's an example of this, where on the left side plot "costs" I'd like to be able to see the stuff currently covered up by the legend

Screenshot from 2023-05-04 14-45-34

@abey79 abey79 added 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users labels Nov 27, 2023
This was referenced Nov 28, 2023
Merged
Merged
Merged
abey79 added a commit that referenced this issue Nov 28, 2023
@abey79
Plot legend visibility and position control (part 1): route `EntityPr…
f7ab1ef 
…operties` to `SpaceViewClass` methods (#4363)

### What

This PR routes the per-space-view, root `EntityProperties` to
`SpaceViewClass`'s `selection_ui()` and `ui()` methods. Note that
although `EntityProperties` are soon to be replaced by bespoke
components, this data path way will remain.

* Prep for #2049

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4363) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4363)
- [Docs
preview](https://rerun.io/preview/bec0a99df08ea8d7e1e2dee9d2ef493ee6af96c2/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/bec0a99df08ea8d7e1e2dee9d2ef493ee6af96c2/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79 added a commit that referenced this issue Nov 28, 2023
@abey79
Plot legend visibility and position control (part 2): minor UI spacin…
8c9ff59 
…g improvement (#4364)

### What

This PR introduce a very minor Selection Panel UI fix where space was
missing between the per-space-view blueprint UI and the Visible Time
Range UI.

<img width="412" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/f5b2b3cf-a099-4746-864f-ff24cf610b31">


* Prep for #2049

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4364) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4364)
- [Docs
preview](https://rerun.io/preview/e082a082518e9e1b70f34e1ade38dafde06e260f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/e082a082518e9e1b70f34e1ade38dafde06e260f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79 added a commit that referenced this issue Nov 28, 2023
@abey79
Plot legend visibility and position control (part 3): legend UI added…
95efb76 
… for both timeseries and bar charts space views (#4365)

### What

Introduce UI controls to set the legend visibility and location for both
timeseries and bar chart space views

<img width="1251" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/0ac44f67-44f8-4c98-8c41-960bc7d8015f">

* Fixes #2049

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4365) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4365)
- [Docs
preview](https://rerun.io/preview/071a456269388f0882bd379b0f88f58ccd9912c8/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/071a456269388f0882bd379b0f88f58ccd9912c8/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
teh-cmc pushed a commit that referenced this issue Nov 30, 2023
@abey79 @teh-cmc
Plot legend visibility and position control (part 1): route `EntityPr…
7f090cb 
…operties` to `SpaceViewClass` methods (#4363)

### What

This PR routes the per-space-view, root `EntityProperties` to
`SpaceViewClass`'s `selection_ui()` and `ui()` methods. Note that
although `EntityProperties` are soon to be replaced by bespoke
components, this data path way will remain.

* Prep for #2049

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4363) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4363)
- [Docs
preview](https://rerun.io/preview/bec0a99df08ea8d7e1e2dee9d2ef493ee6af96c2/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/bec0a99df08ea8d7e1e2dee9d2ef493ee6af96c2/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
teh-cmc pushed a commit that referenced this issue Nov 30, 2023
@abey79 @teh-cmc
Plot legend visibility and position control (part 2): minor UI spacin…
46dd085 
…g improvement (#4364)

### What

This PR introduce a very minor Selection Panel UI fix where space was
missing between the per-space-view blueprint UI and the Visible Time
Range UI.

<img width="412" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/f5b2b3cf-a099-4746-864f-ff24cf610b31">


* Prep for #2049

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4364) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4364)
- [Docs
preview](https://rerun.io/preview/e082a082518e9e1b70f34e1ade38dafde06e260f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/e082a082518e9e1b70f34e1ade38dafde06e260f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
teh-cmc pushed a commit that referenced this issue Nov 30, 2023
@abey79 @teh-cmc
Plot legend visibility and position control (part 3): legend UI added…
5843b17 
… for both timeseries and bar charts space views (#4365)

### What

Introduce UI controls to set the legend visibility and location for both
timeseries and bar chart space views

<img width="1251" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/0ac44f67-44f8-4c98-8c41-960bc7d8015f">

* Fixes #2049

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4365) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4365)
- [Docs
preview](https://rerun.io/preview/071a456269388f0882bd379b0f88f58ccd9912c8/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/071a456269388f0882bd379b0f88f58ccd9912c8/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself ui concerns graphical user interface user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
No milestone
3 participants
@Wumpf @PeterMitrano @abey79