Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new scene should never use the same name as an existing scene #1220

Closed
jleibs opened this issue Feb 12, 2023 · 2 comments · Fixed by #1653
Closed

Creating a new scene should never use the same name as an existing scene #1220

jleibs opened this issue Feb 12, 2023 · 2 comments · Fixed by #1653
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use good first issue Good for newcomers ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented Feb 12, 2023

When creating a "camera" scene in the colmap it confusingly ends up named "image".

The scene is layed out as:
image

And the initial scene is good:
image

However, if I add a third scene for the camera:
image

Then we end up with a second scene named image:
image

I think this scene should be named camera because that's what's in the scene: a camera that contains an image but I'd settle for image2 to at least help me track which is which.

@jleibs jleibs added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use labels Feb 12, 2023
@jleibs
Copy link
Member Author

jleibs commented Feb 12, 2023

In general I'm trying to come up with a scenario where I don't want the last element of the space root to be the default name.

@Wumpf
Copy link
Member

Wumpf commented Feb 12, 2023

This is trivial to fix, just remove the first branch here https://github.com/rerun-io/rerun/blob/main/crates/re_viewer/src/ui/space_view.rs#L65
I'm not sure that's always what we want though. In your example is seems reasonable enough hover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use good first issue Good for newcomers ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants