Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api_demo: set different app_id depending on what demo is being run #1125

Closed
Tracked by #1119
teh-cmc opened this issue Feb 7, 2023 · 5 comments · Fixed by #2599
Closed
Tracked by #1119

api_demo: set different app_id depending on what demo is being run #1125

teh-cmc opened this issue Feb 7, 2023 · 5 comments · Fixed by #2599
Assignees
@emilk
Labels
examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Feb 7, 2023

What the title says.

  • Avoids a poor user experience where one ends up with a bunch of zombie space views
  • Provides interesting analytics for official examples
@teh-cmc teh-cmc added the examples Issues relating to the Rerun examples label Feb 7, 2023
@teh-cmc teh-cmc mentioned this issue Feb 7, 2023
Closed
7 tasks
@Wumpf
Copy link
Member

Wumpf commented Feb 15, 2023

went in!

@Wumpf Wumpf closed this as completed Feb 15, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Feb 15, 2023

lies!

@teh-cmc teh-cmc reopened this Feb 15, 2023
@emilk
Copy link
Member

emilk commented Feb 28, 2023

I don't understand this issues.

What does "active demo/recording/scene" refer to? The currently open recording in the viewer?

When should app_id take it into account? When the example sets the app_it in init? In analytics?

@teh-cmc
Copy link
Member Author

teh-cmc commented Feb 28, 2023

What does "active demo/recording/scene" refer to? The currently open recording in the viewer?

It refers to the application-specific notion of "what's the current dataset", e.g.:

  • For objectron, the app_id should change depending on the dataset being visualized (e.g. book vs bike)
  • For api_demo, the app_id should change depending on the --demo flag
  • etc

@emilk
Copy link
Member

emilk commented Jun 12, 2023

I don't agree on the objectron example - it is the same application regardless of what you visualize, and you should expect to have the same blueprint regardless if you are "scanning" a book or a bike.

For api_demo: for this one I agree (though it is not really an example, and we should either turn it into many small examples or make it into a test)

@emilk emilk changed the title Examples: app_id should take into account active demo/recording/scene apid_demo: set different app_id depending on what demo is being run Jun 12, 2023
@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label Jun 12, 2023
@emilk emilk changed the title apid_demo: set different app_id depending on what demo is being run api_demo: set different app_id depending on what demo is being run Jun 15, 2023
emilk added a commit that referenced this issue Jul 4, 2023
@emilk
test_api: set different app_id based on what test is run
dcd48ce 
Closes #1125
@emilk emilk mentioned this issue Jul 4, 2023
Merged
3 tasks
@emilk emilk self-assigned this Jul 4, 2023
emilk added a commit that referenced this issue Jul 4, 2023
@emilk
test_api: set different app_id based on what test is run (#2599)
ef9386a 
Closes #1125
* #1125

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2599) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2599)
- [Docs
preview](https://rerun.io/preview/pr%3Aemilk%2Fapi_demo_sets_app_id/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aemilk%2Fapi_demo_sets_app_id/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_api: set different app_id based on what test is run rerun-io/rerun
3 participants
@emilk @Wumpf @teh-cmc