-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Initial Space View trait & port of text space views to the new Space …
…View trait system (#2281) <!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Main pieces of: * #2249 * #1873 Introduces a new framework for space view classes that will eventually replace `ViewCategory` (right now the systems live side by side, creating some oddities). Ports text & text-box space views to this new system. ### Why This paves the way for more structured space views, more streamlined blueprint configuration and user defined space views. In fact, this PR already enables user defined space views, but does not yet expose a way to add them to the viewport (this can be done with some small hacks to the space view adding code though and works very well!) ### Future work / discussion There is still a lot of open question on the space view trait and it will require changes as we move the other space views over to it. Most notably, archetypes are defined by have no effect yet! Overall, scene definition can be regarded as experimental at this point. I chose to have a hard separation of `SceneElement` (the successor of `ScenePart`) in the hope of providing a more powerful framework and an easy hook for future parallelization. We'll need to see how this pans out though! Unlike planned, the definition of the space view class trait (as well as implementation utilities) are not in a separate crate, but part of the viewer context since global access to the space view type registry proved very valuable. We could still separate some parts of it out if desirable, but this seems not very important at the moment. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2281
- Loading branch information
Showing
37 changed files
with
1,101 additions
and
316 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
[package] | ||
authors.workspace = true | ||
description = "A Space View that shows text entries in a table and scrolls with the active time." | ||
edition.workspace = true | ||
homepage.workspace = true | ||
license.workspace = true | ||
name = "re_space_view_text" | ||
publish = true | ||
readme = "README.md" | ||
repository.workspace = true | ||
rust-version.workspace = true | ||
version.workspace = true | ||
include = ["../../LICENSE-APACHE", "../../LICENSE-MIT", "**/*.rs", "Cargo.toml"] | ||
|
||
[package.metadata.docs.rs] | ||
all-features = true | ||
|
||
[dependencies] | ||
re_arrow_store.workspace = true | ||
re_components.workspace = true | ||
re_data_store.workspace = true | ||
re_data_ui.workspace = true | ||
re_log_types.workspace = true | ||
re_log.workspace = true | ||
re_query.workspace = true | ||
re_tracing.workspace = true | ||
re_ui.workspace = true | ||
re_viewer_context.workspace = true | ||
|
||
egui.workspace = true | ||
egui_extras.workspace = true | ||
vec1.workspace = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# re_space_view_text | ||
|
||
Part of the [`rerun`](https://github.com/rerun-io/rerun) family of crates. | ||
|
||
[![Latest version](https://img.shields.io/crates/v/re_space_view_text.svg)](https://crates.io/crates/re_space_view_text) | ||
[![Documentation](https://docs.rs/re_space_view_text/badge.svg)](https://docs.rs/re_space_view_text) | ||
![MIT](https://img.shields.io/badge/license-MIT-blue.svg) | ||
![Apache](https://img.shields.io/badge/license-Apache-blue.svg) | ||
|
||
A Space View that shows text entries in a table and scrolls with the active time. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
//! Rerun Text Space Views | ||
//! | ||
//! A Space View that shows text entries in a table and scrolls with the active time. | ||
mod scene_element; | ||
mod space_view_class; | ||
|
||
pub use space_view_class::TextSpaceView; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
fe1869e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
1.25
.batch_points_arrow/encode_log_msg
121947
ns/iter (± 971
)92919
ns/iter (± 728
)1.31
This comment was automatically generated by workflow using github-action-benchmark.