Fix lint.py (#1719)

* Fix bug in lint.py * Fix TODO in msg_bundle.rs
rerun-io · Mar 27, 2023 · f8a263c · f8a263c · github-actions · Mar 27, 2023
1 parent f0285c7
commit f8a263c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/crates/re_log_types/src/msg_bundle.rs b/crates/re_log_types/src/msg_bundle.rs
@@ -34,7 +34,7 @@ use crate::{
 
 // ---
 
-// TODO: can probably make that one pub(crate) already
+// TODO(cmc): can probably make that one pub(crate) already
 /// The errors that can occur when trying to convert between Arrow and `MessageBundle` types
 #[derive(thiserror::Error, Debug)]
 pub enum MsgBundleError {

diff --git a/scripts/lint.py b/scripts/lint.py
@@ -276,7 +276,7 @@ def lint_file(filepath: str, args: Any) -> int:
                 f.writelines(lines_out)
             print(f"{filepath} fixed.")
 
-        num_errors = len(errors)
+        num_errors += len(errors)
 
     return num_errors
Benchmark suite	Current: `f8a263c`	Previous: `f0285c7`	Ratio
`datastore/insert/batch/rects/insert`	`617798` ns/iter (`± 2294`)	`605813` ns/iter (`± 2916`)	`1.02`
`datastore/latest_at/batch/rects/query`	`1830` ns/iter (`± 1`)	`1853` ns/iter (`± 9`)	`0.99`
`datastore/latest_at/missing_components/primary`	`289` ns/iter (`± 0`)	`287` ns/iter (`± 1`)	`1.01`
`datastore/latest_at/missing_components/secondaries`	`447` ns/iter (`± 0`)	`438` ns/iter (`± 2`)	`1.02`
`datastore/range/batch/rects/query`	`153749` ns/iter (`± 251`)	`151846` ns/iter (`± 1511`)	`1.01`
`mono_points_arrow/generate_message_bundles`	`47092378` ns/iter (`± 853262`)	`46513917` ns/iter (`± 622483`)	`1.01`
`mono_points_arrow/generate_messages`	`123513169` ns/iter (`± 1380848`)	`123500647` ns/iter (`± 1110759`)	`1.00`
`mono_points_arrow/encode_log_msg`	`157619842` ns/iter (`± 1814858`)	`156246217` ns/iter (`± 984562`)	`1.01`
`mono_points_arrow/encode_total`	`329033469` ns/iter (`± 1723866`)	`327457744` ns/iter (`± 1935988`)	`1.00`
`mono_points_arrow/decode_log_msg`	`180134730` ns/iter (`± 875308`)	`179138730` ns/iter (`± 1094507`)	`1.01`
`mono_points_arrow/decode_message_bundles`	`53748777` ns/iter (`± 782433`)	`54574594` ns/iter (`± 644866`)	`0.98`
`mono_points_arrow/decode_total`	`231988721` ns/iter (`± 1345301`)	`231466995` ns/iter (`± 1461577`)	`1.00`
`batch_points_arrow/generate_message_bundles`	`287678` ns/iter (`± 874`)	`286488` ns/iter (`± 2428`)	`1.00`
`batch_points_arrow/generate_messages`	`6093` ns/iter (`± 18`)	`6111` ns/iter (`± 43`)	`1.00`
`batch_points_arrow/encode_log_msg`	`392686` ns/iter (`± 1010`)	`385179` ns/iter (`± 2164`)	`1.02`
`batch_points_arrow/encode_total`	`708178` ns/iter (`± 3015`)	`694213` ns/iter (`± 4347`)	`1.02`
`batch_points_arrow/decode_log_msg`	`366401` ns/iter (`± 1746`)	`353613` ns/iter (`± 1783`)	`1.04`
`batch_points_arrow/decode_message_bundles`	`1609` ns/iter (`± 5`)	`1567` ns/iter (`± 9`)	`1.03`
`batch_points_arrow/decode_total`	`372919` ns/iter (`± 1592`)	`357799` ns/iter (`± 1669`)	`1.04`
`arrow_mono_points/insert`	`6641633300` ns/iter (`± 18770550`)	`6204320834` ns/iter (`± 17905183`)	`1.07`
`arrow_mono_points/query`	`1929164` ns/iter (`± 33196`)	`1724079` ns/iter (`± 17922`)	`1.12`
`arrow_batch_points/insert`	`3323001` ns/iter (`± 76848`)	`3033644` ns/iter (`± 15959`)	`1.10`
`arrow_batch_points/query`	`15249` ns/iter (`± 105`)	`15406` ns/iter (`± 99`)	`0.99`
`arrow_batch_vecs/insert`	`44494` ns/iter (`± 142`)	`42562` ns/iter (`± 216`)	`1.05`
`arrow_batch_vecs/query`	`480999` ns/iter (`± 666`)	`479101` ns/iter (`± 5927`)	`1.00`
`tuid/Tuid::random`	`34` ns/iter (`± 0`)	`34` ns/iter (`± 0`)	`1`