-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make Visible History UI more ergonomic and show inherited values (#4222)
### What Update the Visible History UI: - It now shows up in its own collapsible section in the Selection Panel. - It makes it more clear that the item is either inheriting or overriding the settings. - When inheriting, the inherited settings are displayed. - When overriding, the editor as a more intuitive UI (fixes #4190) - The editor also addresses a bug for timeline with large values (e.g. actual dates) but small spans, like `log_time` (fixes #4210) - The test script now has a whole lot of timelines with all sorts of spans and offsets, for test purposes. Side effects on the code base: - slight tweak on the querying (latest at is used whenever visible time range boundaries resolve to the same absolute time) - added `individual_properties` to `DataResult`, to allow UI to display/edit it - added support to erase property overrides in `DataResult::save_override` - added a new collapsing header widget in re_ui, to match our style Playground RRD: [test_visible_history.rrd.zip](https://github.com/rerun-io/rerun/files/13348321/test_visible_history.rrd.zip) (same as the output of `tests/python/visible_history_playground/main.py`). ### Screenshots New "Visible Time Range" UI in the blueprint section: <img width="429" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/c215560f-7679-442a-afe9-561d6cae6285"> When Override is selected: <img width="379" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/f9b1651f-0d29-4085-952b-3f55b0c3c469"> When operating on "large" time (e.g. `log_time`): <img width="393" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/67f69dd9-1e90-4d04-9c8b-5fe2696c92bc"> Same when using the Default/Inherited value: <img width="378" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/ffbfa49a-54bb-472b-be47-25a800d4f771"> <br/> <br/> <details><summary>Older screenshots which aged like milk, for posterity.</summary> On (supported) space views, the choice is "Default vs. Override": <img width="336" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/69ab4063-cd79-4c56-a01a-9bf54d74070a"> On groups and entities, the choice is "Inherited vs. Override": <img width="343" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/3911c456-97b1-48ed-aa69-9cbb3cf92611"> On timeseries space views, the default reflects the fact that the default behaviour is, in fact, different from 2D/3D space views <img width="345" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/35692f66-dcb3-419b-8246-2823d802c39b"> When overriding, the text becomes "editable": <img width="338" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/641758ec-2762-4c13-b87f-de1cec144ea0"> Same, when inherited: <img width="313" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/52272daa-d215-40e4-8f7d-2caeea522434"> With timelines with "large" times, an offset is extracted and explicitly displayed, while the unit in the time editor adapts to the actual span: <img width="405" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/dfa887d5-aa6c-49aa-be1c-704045788422"> Same inherited: <img width="438" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/ea748355-5293-422a-8f25-6092529b6452"> </details> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4222) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4222) - [Docs preview](https://rerun.io/preview/69df7cdce2fa9c3899b2b04aa2bf487807485c02/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/69df7cdce2fa9c3899b2b04aa2bf487807485c02/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
- Loading branch information
Showing
13 changed files
with
1,025 additions
and
401 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
f586c04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
1.25
.mono_points_arrow/generate_message_bundles
29013786
ns/iter (± 827135
)18885391
ns/iter (± 154605
)1.54
mono_points_arrow_batched/generate_message_bundles
19002850
ns/iter (± 1005353
)14629999
ns/iter (± 31790
)1.30
mono_points_arrow_batched/encode_total
28574722
ns/iter (± 1908661
)20637940
ns/iter (± 125526
)1.38
This comment was automatically generated by workflow using github-action-benchmark.