Skip to content

Commit

Permalink
Fix visibility toggle for maximized Space Views (#2806)
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf authored Jul 25, 2023
1 parent b4cd340 commit efaa506
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions crates/re_viewport/src/viewport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ impl<'a, 'b> Viewport<'a, 'b> {
if let Some(space_view_id) = blueprint.maximized {
if !blueprint.space_views.contains_key(&space_view_id) {
blueprint.maximized = None; // protect against bad deserialized data
} else if let Some(tile_id) = blueprint.tree.tiles.find_pane(&space_view_id) {
if !blueprint.tree.tiles.is_visible(tile_id) {
blueprint.maximized = None; // Automatically de-maximize views that aren't visible anymore.
}
}
}

Expand Down

1 comment on commit efaa506

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.

Benchmark suite Current: efaa506 Previous: b4cd340 Ratio
batch_points_arrow/encode_log_msg 85595 ns/iter (± 1938) 49230 ns/iter (± 98) 1.74

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.