Skip to content

Commit

Permalink
pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
teh-cmc committed Nov 15, 2023
1 parent dd3565b commit eb01c98
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion crates/re_arrow_store/src/store_event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ mod tests {

use super::*;

/// A simple [`StoreView`] for test purposes that keeps track of the quantity of data available
/// A simple store subscriber for test purposes that keeps track of the quantity of data available
/// in the store a the lowest level of detail.
///
/// The counts represent numbers of rows: e.g. how many unique rows contain this entity path?
Expand Down
4 changes: 2 additions & 2 deletions crates/re_arrow_store/src/store_view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use crate::{DataStore, StoreEvent};
// TODO(cmc): Not sure why I need the extra Box here, RwLock should be `?Sized`.
type SharedStoreView = RwLock<Box<dyn StoreView>>;

/// A [`StoreView`] subscribes to atomic changes in one or more [`DataStore`]s through [`StoreEvent`]s.
/// A [`StoreView`] subscribes to atomic changes from all [`DataStore`]s through [`StoreEvent`]s.
///
/// [`StoreView`]s can be used to build both secondary indices and trigger systems.
//
Expand All @@ -34,7 +34,7 @@ pub trait StoreView: std::any::Any + Send + Sync {
/// ```
fn as_any_mut(&mut self) -> &mut dyn std::any::Any;

/// The core of this trait: get notified of changes happening in one or more [`DataStore`]s.
/// The core of this trait: get notified of changes happening in all [`DataStore`]s.
///
/// This will be called automatically by the [`DataStore`] itself if the view has been
/// registered: [`DataStore::register_view`].
Expand Down

0 comments on commit eb01c98

Please sign in to comment.