Merge branch 'main' into new-depth-guided-stable-diffusion

.github/pull_request_template.md

@@ -16,9 +16,9 @@ To get an auto-generated PR description you can put "copilot:summary" or "copilo
 * [ ] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
 * [ ] I've included a screenshot or gif (if applicable)
 * [ ] I have tested the web demo (if applicable):
-  * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html)
-  * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
-  * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
+  * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}})
+  * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
+  * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
 * [ ] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
 * [ ] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
 

.github/workflows/README.md

@@ -4,72 +4,75 @@ Our CI workflows make heavy usage of [Reusable Workflows](https://docs.github.co
 Or integrated into CI jobs such has `on_pull_request.yml` or `on_main.yml`.
 
 By convention:
-- All reusable workflows start with the `reusable_` prefix.
-- All workflows that are triggered via `workflow_dispatch` start with the `manual_` prefix.
-- All workflows that are triggered via an event start with the `on_` prefix.
-  - `on_pull_request` is triggered on pull requests.
-  - `on_push_main` is triggered on pushes to the main branch.
+
+-   All reusable workflows start with the `reusable_` prefix.
+-   All workflows that are triggered via `workflow_dispatch` start with the `manual_` prefix.
+-   All workflows that are triggered via an event start with the `on_` prefix.
+    -   `on_pull_request` is triggered on pull requests.
+    -   `on_push_main` is triggered on pushes to the main branch.
 
 If you are going to be doing any editing of workflows, the
 [VS Code extension](https://marketplace.visualstudio.com/items?itemName=cschleiden.vscode-github-actions)
 for GitHub Actions is highly recommended.
 
 ## Reusable Workflows
-- [reusable_checks.yml](reusable_checks.yml) - These are all the checks that run to ensure the code is formatted,
-  linted, and tested. This job produces no artifacts other than a pass/fail criteria for the build.
-  - `SAVE_CACHE` - If true, the rust cache will be saved. Generally we only do this for builds on `main`
-- [reusable_bench.yml](reusable_bench.yml) - This job runs the benchmarks to check for performance regressions.
-  - `SAVE_BENCH` - If true, then the benchmark results are saved to update https://ref.rerun.io/dev/bench/
-- [reusable_deploy_docs](reusable_deploy_docs.yml) - This job deploys the python and rust documentation to https://ref.rerun.io
-  - `PY_AND_CPP_DOCS_VERSION_NAME` - The name to use for versioning the python docs. This should generally match the version in
-    `Cargo.toml`.
-  - `UPDATE_LATEST` - If true, then the docs will be deployed to `latest/` as well as the versioned directory.
-- [reusable_build_and_test_wheels.yml](reusable_build_and_test_wheels.yml) - This job builds the wheels, runs the
-end-to-end test, and produces a sample RRD. The artifacts are accessible via GitHub artifacts, but not otherwise
-uploaded anywhere.
-  - `MATURIN_FEATURE_FLAGS` - The feature flags to pass to maturin.
-  - `PLATFORM` - Which platform to build for: `linux`, `macos-arm`, `macos-intel`, or `windows`.
-  - `RELEASE_VERSION` - If producing a release, the version number. This must match the version in `Cargo.toml`.
-  - `RRD_ARTIFACT_NAME` - Intermediate name of the GitHub rrd artifact for passing to `reusable_upload_wheels.yml`
-  - `SAVE_CACHE` - If true, the rust cache will be saved. Generally we only do this for builds on `main`
-  - `WHEEL_ARTIFACT_NAME` - Intermediate name of the GitHub wheel artifact for passing to `reusable_upload_wheels.yml`
-- [reusable_upload_wheels.yml](reusable_upload_wheels.yml) - This job uploads the wheels to google cloud
-  - `RRD_ARTIFACT_NAME` - Intermediate name of the GitHub rrd artifact. This should match the name passed to
-    `reusable_build_and_test_wheels.yml`
-  - `WHEEL_ARTIFACT_NAME` - Intermediate name of the GitHub wheel artifact. This should match the name passed to
-    `reusable_build_and_test_wheels.yml`
-- [reusable_build_web.yml](reusable_build_web.yml) - This job builds the wasm artifacts for the web.
-  - `RELEASE_VERSION` - If producing a release, the version number. This must match the version in `Cargo.toml`.
-- [reusable_upload_web.yml](reusable_upload_web.yml) - This job uploads the web assets to google cloud. By default this
-  only uploads to: `app.rerun.io/commit/<commit>/`
-  - `MARK_TAGGED_VERSION` - If true, then the web assets will go to `app.rerun.io/version/<RELEASE_VERSION>`
-  - `RELEASE_VERSION` - If producing a release, the version number.
-  - `RRD_ARTIFACT_NAME` - Intermediate name of the GitHub rrd artifact. This should match the name passed to
-    `reusable_build_and_test_wheels.yml`
-  - `UPLOAD_COMMIT_OVERRIDE` - If set, will replace the value of `<commit>`. This is necessary because we want pull
-  request builds associated with their originating commit, even if the web-build happens on an ephemeral merge-commit.
-- [reusable_build_web_demo.yml](reusable_build_web.yml) - This job builds the assets uploaded to `demo.rerun.io`.
-  - `SOURCE_LINK_COMMIT_OVERRIDE` - If set, will replace the value of `<commit>` in the built app. This ensures that the
-  source code link in the built app always points to the pull request's `HEAD`.
-- [reusable_upload_web_demo.yml](reusable_upload_web_demo.yml) - This job uploads the `demo.rerun.io` assets to google cloud. By default this
-  only uploads to: `demo.rerun.io/commit/<commit>/`
-  - `MARK_TAGGED_VERSION` - If true, then the web assets will go to `demo.rerun.io/version/<RELEASE_VERSION>`
-  - `RELEASE_VERSION` - If producing a release, the version number.
-  - `UPLOAD_COMMIT_OVERRIDE` - If set, will replace the value of `<commit>`. This is necessary because we want pull
-  request builds associated with their originating commit, even if the web-build happens on an ephemeral merge-commit.
-  - `PR_NUMBER` - If set, will upload `demo.rerun.io/pr/<PR_NUMBER>`
-- [reusable_pr_summary.yml](reusable_pr_summary.yml) - This job updates the PR summary with the results of the CI run.
-  - This summary can be found at:
-  `https://build.rerun.io/pr/<PR_NUMBER>/`
-  - `PR_NUMBER` - The PR number to update. This will generally be set by the `on_pull_request.yml` workflow using:
-  `${{github.event.pull_request.number}}`
+
+-   [reusable_checks.yml](reusable_checks.yml) - These are all the checks that run to ensure the code is formatted,
+    linted, and tested. This job produces no artifacts other than a pass/fail criteria for the build.
+    -   `SAVE_CACHE` - If true, the rust cache will be saved. Generally we only do this for builds on `main`
+-   [reusable_bench.yml](reusable_bench.yml) - This job runs the benchmarks to check for performance regressions.
+    -   `SAVE_BENCH` - If true, then the benchmark results are saved to update https://ref.rerun.io/dev/bench/
+-   [reusable_deploy_docs](reusable_deploy_docs.yml) - This job deploys the python and rust documentation to https://ref.rerun.io
+    -   `PY_AND_CPP_DOCS_VERSION_NAME` - The name to use for versioning the python docs. This should generally match the version in
+        `Cargo.toml`.
+    -   `UPDATE_LATEST` - If true, then the docs will be deployed to `latest/` as well as the versioned directory.
+-   [reusable_build_and_test_wheels.yml](reusable_build_and_test_wheels.yml) - This job builds the wheels, runs the
+    end-to-end test, and produces a sample RRD. The artifacts are accessible via GitHub artifacts, but not otherwise
+    uploaded anywhere.
+    -   `MATURIN_FEATURE_FLAGS` - The feature flags to pass to maturin.
+    -   `PLATFORM` - Which platform to build for: `linux-arm64`, `linux-x64`, `macos-arm64`, `macos-x64`, or `windows-x64`.
+    -   `RELEASE_VERSION` - If producing a release, the version number. This must match the version in `Cargo.toml`.
+    -   `RRD_ARTIFACT_NAME` - Intermediate name of the GitHub rrd artifact for passing to `reusable_upload_wheels.yml`
+    -   `SAVE_CACHE` - If true, the rust cache will be saved. Generally we only do this for builds on `main`
+    -   `WHEEL_ARTIFACT_NAME` - Intermediate name of the GitHub wheel artifact for passing to `reusable_upload_wheels.yml`
+-   [reusable_upload_wheels.yml](reusable_upload_wheels.yml) - This job uploads the wheels to google cloud
+    -   `RRD_ARTIFACT_NAME` - Intermediate name of the GitHub rrd artifact. This should match the name passed to
+        `reusable_build_and_test_wheels.yml`
+    -   `WHEEL_ARTIFACT_NAME` - Intermediate name of the GitHub wheel artifact. This should match the name passed to
+        `reusable_build_and_test_wheels.yml`
+-   [reusable_build_web.yml](reusable_build_web.yml) - This job builds the wasm artifacts for the web.
+    -   `RELEASE_VERSION` - If producing a release, the version number. This must match the version in `Cargo.toml`.
+-   [reusable_upload_web.yml](reusable_upload_web.yml) - This job uploads the web assets to google cloud. By default this
+    only uploads to: `app.rerun.io/commit/<commit>/`
+    -   `MARK_TAGGED_VERSION` - If true, then the web assets will go to `app.rerun.io/version/<RELEASE_VERSION>`
+    -   `RELEASE_VERSION` - If producing a release, the version number.
+    -   `RRD_ARTIFACT_NAME` - Intermediate name of the GitHub rrd artifact. This should match the name passed to
+        `reusable_build_and_test_wheels.yml`
+    -   `UPLOAD_COMMIT_OVERRIDE` - If set, will replace the value of `<commit>`. This is necessary because we want pull
+        request builds associated with their originating commit, even if the web-build happens on an ephemeral merge-commit.
+-   [reusable_build_web_demo.yml](reusable_build_web.yml) - This job builds the assets uploaded to `demo.rerun.io`.
+    -   `SOURCE_LINK_COMMIT_OVERRIDE` - If set, will replace the value of `<commit>` in the built app. This ensures that the
+        source code link in the built app always points to the pull request's `HEAD`.
+-   [reusable_upload_web_demo.yml](reusable_upload_web_demo.yml) - This job uploads the `demo.rerun.io` assets to google cloud. By default this
+    only uploads to: `demo.rerun.io/commit/<commit>/`
+    -   `MARK_TAGGED_VERSION` - If true, then the web assets will go to `demo.rerun.io/version/<RELEASE_VERSION>`
+    -   `RELEASE_VERSION` - If producing a release, the version number.
+    -   `UPLOAD_COMMIT_OVERRIDE` - If set, will replace the value of `<commit>`. This is necessary because we want pull
+        request builds associated with their originating commit, even if the web-build happens on an ephemeral merge-commit.
+    -   `PR_NUMBER` - If set, will upload `demo.rerun.io/pr/<PR_NUMBER>`
+-   [reusable_pr_summary.yml](reusable_pr_summary.yml) - This job updates the PR summary with the results of the CI run.
+    -   This summary can be found at:
+        `https://build.rerun.io/pr/<PR_NUMBER>/`
+    -   `PR_NUMBER` - The PR number to update. This will generally be set by the `on_pull_request.yml` workflow using:
+        `${{github.event.pull_request.number}}`
 
 ## Manual Workflows
-- [manual_dispatch](manual_dispatch.yml) - This workflow is used to manually trigger the assorted reusable workflows for
-  testing.
-  - See the workflow file for the list of parameters.
-- [manual_build_wheels_for_pr.yml](manual_build_wheels_for_pr.yml) - This workflow can be dispatched on a branch and
-  will build all of the wheels for the associated pull-request. Uses:
-  - [reusable_build_and_test_wheels.yml](reusable_build_and_test_wheels.yml)
-  - [reusable_upload_wheels.yml](reusable_upload_wheels.yml)
-  - [reusable_pr_summary.yml](reusable_pr_summary.yml)
+
+-   [manual_dispatch](manual_dispatch.yml) - This workflow is used to manually trigger the assorted reusable workflows for
+    testing.
+    -   See the workflow file for the list of parameters.
+-   [manual_build_wheels_for_pr.yml](manual_build_wheels_for_pr.yml) - This workflow can be dispatched on a branch and
+    will build all of the wheels for the associated pull-request. Uses:
+    -   [reusable_build_and_test_wheels.yml](reusable_build_and_test_wheels.yml)
+    -   [reusable_upload_wheels.yml](reusable_upload_wheels.yml)
+    -   [reusable_pr_summary.yml](reusable_pr_summary.yml)

.github/workflows/contrib_checks.yml

@@ -202,7 +202,7 @@ jobs:
         with:
           command: run
           # We build in release so that we can reuse the results for actual publishing, if necessary
-          args: --locked -p re_build_web_viewer -- --release
+          args: --locked -p re_build_web_viewer -- --release -g
 
   toml-lints:
     name: Lint TOML files

.github/workflows/contrib_rerun_py.yml

@@ -53,7 +53,7 @@ jobs:
       - name: Build Wheel
         uses: PyO3/maturin-action@v1
         with:
-          maturin-version: "1.4.0"
+          maturin-version: "1.5.1"
           manylinux: manylinux_2_31
           container: off
           command: build

.github/workflows/cpp_matrix_full.json

@@ -22,7 +22,7 @@
         {
             "name": "Mac aarch64",
             "runs_on": "macos-latest-large",
-            "cache_key": "build-macos-arm",
+            "cache_key": "build-macos-arm64",
             "extra_env_vars": "RERUN_USE_ASAN=1"
         }
     ]

.github/workflows/documentation.yaml

@@ -38,10 +38,11 @@ jobs:
           # * skip changelog PR links (so many)
           # * skip speculative links
           # * Stackoverflow links are no longer accessible from CI.
+          # * Tuxfamily.org links are down intermittently.
           # * Nyud links are down every now and then.
           # * TODO(#4085): https://rerun-io.github.io/rerun/dev/bench/ often 404:s for unknown reasons
           # * TODO(#4556): remove the `static.rerun.io` and `github.com` skips
-          linksToSkip: "https://stackoverflow.com/.*, https://cs.nyu.edu/~silberman/datasets/nyu_depth_v2.html, https://static.rerun.io/.*, https://github.com/.*, https://crates.io/crates/.*, https://github.com/rerun-io/rerun/pull/.*, .*?speculative-link, https://rerun-io.github.io/rerun/dev/bench/"
+          linksToSkip: "https://stackoverflow.com/.*, https://eigen.tuxfamily.org/, https://cs.nyu.edu/~silberman/datasets/nyu_depth_v2.html, https://static.rerun.io/.*, https://github.com/.*, https://crates.io/crates/.*, https://github.com/rerun-io/rerun/pull/.*, .*?speculative-link, https://rerun-io.github.io/rerun/dev/bench/"
           retry: true
           retryErrors: true
           retryErrorsCount: 5

.github/workflows/on_push_main.yml

@@ -87,12 +87,12 @@ jobs:
 
   build-examples:
     name: "Build Examples"
-    needs: [build-wheel-linux]
+    needs: [build-wheel-linux-x64]
     uses: ./.github/workflows/reusable_build_examples.yml
     with:
       CONCURRENCY: push-${{ github.ref_name }}
       CHANNEL: main
-      WHEEL_ARTIFACT_NAME: linux-wheel
+      WHEEL_ARTIFACT_NAME: linux-x64-wheel
     secrets: inherit
 
   track-sizes:
@@ -359,7 +359,7 @@ jobs:
             Please report any issues you find.
 
             ## Example Hosted App
-            https://app.rerun.io/commit/${{ env.SHORT_SHA }}
+            https://rerun.io/viewer/commit/${{ env.SHORT_SHA }}
 
             ## Wheels can be installed with:
             ```

.github/workflows/release.yml

@@ -238,7 +238,6 @@ jobs:
     with:
       release-version: ${{ needs.version.outputs.current }}
       concurrency: ${{ github.ref_name }}
-      linux-wheel-name: linux-wheel
       release-commit: ${{ needs.version.outputs.release-commit }}
     secrets: inherit
 
@@ -250,7 +249,7 @@ jobs:
       release-version: ${{ needs.version.outputs.current }}
       release-commit: ${{ needs.version.outputs.release-commit }}
       concurrency: ${{ github.ref_name }}
-      wheel-artifact-name: linux-wheel
+      wheel-artifact-name: linux-x64-wheel
       update-latest: ${{ inputs.release-type == 'final' }}
     secrets: inherit
 
@@ -446,11 +445,11 @@ jobs:
           short_commit_hash=$(echo ${{ needs.version.outputs.release-commit }} | cut -c1-7)
 
           if [ ${{ inputs.release-type }} = "final" ]; then
-            web_app_link="https://app.rerun.io/version/${{ needs.version.outputs.final }}"
+            web_app_link="https://rerun.io/viewer/version/${{ needs.version.outputs.final }}"
             rerun_io_docs_link="https://rerun.io/docs"
             py_docs_link="https://ref.rerun.io/docs/python/${{ needs.version.outputs.final }}"
           else
-            web_app_link="https://app.rerun.io/commit/$short_commit_hash"
+            web_app_link="https://rerun.io/viewer/commit/$short_commit_hash"
             rerun_io_docs_link="https://rerun.io/preview/$short_commit_hash/docs"
             py_docs_link="https://ref.rerun.io/docs/python/dev"
           fi

.github/workflows/reusable_build_and_upload_rerun_c.yml

@@ -76,13 +76,13 @@ jobs:
             linux-arm64)
               runner="buildjet-8vcpu-ubuntu-2204-arm"
               target="aarch64-unknown-linux-gnu"
-              container="{'image': 'rerunio/ci_docker:0.12.0'}"
+              container="'rerunio/ci_docker:0.12.0'"
               lib_name="librerun_c.a"
               ;;
             linux-x64)
               runner="ubuntu-latest-16-cores"
               target="x86_64-unknown-linux-gnu"
-              container="{'image': 'rerunio/ci_docker:0.12.0'}"
+              container="'rerunio/ci_docker:0.12.0'"
               lib_name="librerun_c.a"
               ;;
             windows-x64)
@@ -116,7 +116,11 @@ jobs:
     needs: [set-config]
 
     runs-on: ${{ needs.set-config.outputs.RUNNER }}
-    container: ${{ fromJson(needs.set-config.outputs.CONTAINER) }}
+    container:
+      image: ${{ fromJson(needs.set-config.outputs.CONTAINER) }}
+      credentials:
+        username: ${{ secrets.DOCKER_HUB_USER }}
+        password: ${{ secrets.DOCKER_HUB_TOKEN }}
 
     steps:
       - name: Show context

.github/workflows/reusable_build_and_upload_rerun_cli.yml

@@ -77,13 +77,13 @@ jobs:
             linux-arm64)
               runner="buildjet-8vcpu-ubuntu-2204-arm"
               target="aarch64-unknown-linux-gnu"
-              container="{'image': 'rerunio/ci_docker:0.12.0'}"
+              container="'rerunio/ci_docker:0.12.0'"
               bin_name="rerun"
               ;;
             linux-x64)
               runner="ubuntu-latest-16-cores"
               target="x86_64-unknown-linux-gnu"
-              container="{'image': 'rerunio/ci_docker:0.12.0'}"
+              container="'rerunio/ci_docker:0.12.0'"
               bin_name="rerun"
               ;;
             windows-x64)
@@ -117,7 +117,11 @@ jobs:
     needs: [set-config]
 
     runs-on: ${{ needs.set-config.outputs.RUNNER }}
-    container: ${{ fromJson(needs.set-config.outputs.CONTAINER) }}
+    container:
+      image: ${{ fromJson(needs.set-config.outputs.CONTAINER) }}
+      credentials:
+        username: ${{ secrets.DOCKER_HUB_USER }}
+        password: ${{ secrets.DOCKER_HUB_TOKEN }}
 
     steps:
       - name: Show context
@@ -153,7 +157,7 @@ jobs:
       - name: Build web-viewer (release)
         shell: bash
         run: |
-          pixi run cargo run --locked -p re_build_web_viewer -- --release
+          pixi run cargo run --locked -p re_build_web_viewer -- --release -g
 
       # This does not run in the pixi environment, doing so
       # causes it to select the wrong compiler on macos-arm64