Skip to content

Commit

Permalink
indicator component for bar chart spawning now required (tensor compo…
Browse files Browse the repository at this point in the history
…nent won't do it alone anymore)
  • Loading branch information
Wumpf committed Jan 19, 2024
1 parent 05d1353 commit df90c70
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions crates/re_space_view_bar_chart/src/visualizer_system.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,7 @@ impl VisualizerSystem for BarChartVisualizerSystem {
}

fn indicator_components(&self) -> ComponentNameSet {
// TODO(#3342): For now, we relax the indicator component heuristics on bar charts so that
// logging a 1D tensor also results in a bar chart view, rather than a broken viewer (see #3709).
// Ideally though, this should be implemented using an heuristic fallback mechanism.
[BarChart::indicator().name(), Tensor::indicator().name()]
.into_iter()
.collect()
std::iter::once(BarChart::indicator().name()).collect()
}

fn applicability_filter(&self) -> Option<Box<dyn VisualizerAdditionalApplicabilityFilter>> {
Expand Down

0 comments on commit df90c70

Please sign in to comment.