Skip to content

Commit

Permalink
Fix crash when trying to do picking on depth clouds
Browse files Browse the repository at this point in the history
  • Loading branch information
@emilk
emilk committed Apr 4, 2023
1 parent 29a13ea commit d94ca3d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/re_renderer/src/renderer/depth_cloud.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ impl Renderer for DepthCloudRenderer {

let bind_group = match phase {
DrawPhase::OutlineMask => &instance.bind_group_outline,
DrawPhase::Opaque => &instance.bind_group_opaque,
DrawPhase::PickingLayer | DrawPhase::Opaque => &instance.bind_group_opaque,
_ => unreachable!(),
};

Expand Down

1 comment on commit d94ca3d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: d94ca3d Previous: 29a13ea Ratio
arrow2/size_bytes/primitive/rows=10000/instances=100/array 149363 ns/iter (± 918) 148300 ns/iter (± 743) 1.01
arrow2/size_bytes/primitive/rows=10000/instances=100/vec 3285 ns/iter (± 8) 3288 ns/iter (± 21) 1.00
arrow2/size_bytes/primitive/rows=10000/instances=100/vec/erased 17724 ns/iter (± 17) 17720 ns/iter (± 99) 1.00
arrow2/size_bytes/struct/rows=10000/instances=100/array 491970 ns/iter (± 3490) 501737 ns/iter (± 4053) 0.98
arrow2/size_bytes/struct/rows=10000/instances=100/vec 3288 ns/iter (± 9) 3272 ns/iter (± 30) 1.00
arrow2/size_bytes/struct/rows=10000/instances=100/vec/erased 17729 ns/iter (± 31) 17571 ns/iter (± 149) 1.01
arrow2/size_bytes/struct_large/rows=10000/instances=100/array 3796576 ns/iter (± 311267) 3611445 ns/iter (± 295981) 1.05
arrow2/size_bytes/struct_large/rows=10000/instances=100/vec 3978 ns/iter (± 13) 3934 ns/iter (± 40) 1.01
arrow2/size_bytes/struct_large/rows=10000/instances=100/vec/erased 17740 ns/iter (± 60) 17612 ns/iter (± 210) 1.01
arrow2/erased_clone/primitive/rows=10000/instances=100/cell/arc_erased 783263 ns/iter (± 2196) 770047 ns/iter (± 4046) 1.02
arrow2/erased_clone/primitive/rows=10000/instances=100/cell/wrapped_in_arc 198930 ns/iter (± 1569) 189442 ns/iter (± 1755) 1.05
arrow2/erased_clone/primitive/rows=10000/instances=100/array 750185 ns/iter (± 2279) 741950 ns/iter (± 3757) 1.01
arrow2/erased_clone/primitive/rows=10000/instances=100/array/downcast_first 345005 ns/iter (± 1144) 357577 ns/iter (± 3832) 0.96
arrow2/erased_clone/primitive/rows=10000/instances=100/vec/full_copy 1027097 ns/iter (± 16175) 1020624 ns/iter (± 14264) 1.01
arrow2/erased_clone/primitive/rows=10000/instances=100/vec/wrapped_in_arc 128568 ns/iter (± 401) 127077 ns/iter (± 870) 1.01
arrow2/erased_clone/struct/rows=10000/instances=100/cell/arc_erased 4374814 ns/iter (± 127018) 4214637 ns/iter (± 105458) 1.04
arrow2/erased_clone/struct/rows=10000/instances=100/cell/wrapped_in_arc 287255 ns/iter (± 701) 279796 ns/iter (± 2056) 1.03
arrow2/erased_clone/struct/rows=10000/instances=100/array 4258609 ns/iter (± 78409) 4120116 ns/iter (± 61539) 1.03
arrow2/erased_clone/struct/rows=10000/instances=100/array/downcast_first 3619118 ns/iter (± 58856) 3550125 ns/iter (± 36481) 1.02
arrow2/erased_clone/struct/rows=10000/instances=100/vec/full_copy 1293350 ns/iter (± 14984) 1283442 ns/iter (± 24136) 1.01
arrow2/erased_clone/struct/rows=10000/instances=100/vec/wrapped_in_arc 128546 ns/iter (± 292) 126538 ns/iter (± 1372) 1.02
arrow2/erased_clone/struct_large/rows=10000/instances=100/cell/arc_erased 47406613 ns/iter (± 338387) 53470183 ns/iter (± 925361) 0.89
arrow2/erased_clone/struct_large/rows=10000/instances=100/cell/wrapped_in_arc 168731 ns/iter (± 837) 168703 ns/iter (± 1263) 1.00
arrow2/erased_clone/struct_large/rows=10000/instances=100/array 46492032 ns/iter (± 382216) 52087011 ns/iter (± 883710) 0.89
arrow2/erased_clone/struct_large/rows=10000/instances=100/array/downcast_first 44560383 ns/iter (± 355142) 50096180 ns/iter (± 847690) 0.89
arrow2/erased_clone/struct_large/rows=10000/instances=100/vec/full_copy 4543857 ns/iter (± 142636) 5413612 ns/iter (± 312427) 0.84
arrow2/erased_clone/struct_large/rows=10000/instances=100/vec/wrapped_in_arc 127252 ns/iter (± 271) 126747 ns/iter (± 824) 1.00
arrow2_convert/serialize/primitive/instances=100000/arrow2_convert 414447 ns/iter (± 1298) 415436 ns/iter (± 4284) 1.00
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_values 19581 ns/iter (± 93) 19542 ns/iter (± 384) 1.00
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_vec 19498 ns/iter (± 103) 19669 ns/iter (± 207) 0.99
arrow2_convert/deserialize/primitive/instances=100000/arrow2_convert 96377 ns/iter (± 209) 96288 ns/iter (± 508) 1.00
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_checks 163376 ns/iter (± 480) 160674 ns/iter (± 1112) 1.02
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_bypass 58188 ns/iter (± 148) 58643 ns/iter (± 241) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 10815839 ns/iter (± 272848) 10638674 ns/iter (± 721417) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=0 12957845 ns/iter (± 422964) 12800212 ns/iter (± 452803) 1.01
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2 12514310 ns/iter (± 527432) 12123770 ns/iter (± 638739) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=32 11179528 ns/iter (± 414170) 10600992 ns/iter (± 454300) 1.05
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2048 10962498 ns/iter (± 422087) 10847035 ns/iter (± 710500) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/insert/default 10935737 ns/iter (± 506350) 10224985 ns/iter (± 403984) 1.07
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=0 12849798 ns/iter (± 622294) 11999563 ns/iter (± 580359) 1.07
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2 12390150 ns/iter (± 596166) 11807113 ns/iter (± 596072) 1.05
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=32 10661511 ns/iter (± 411639) 10482180 ns/iter (± 413209) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2048 10266348 ns/iter (± 368447) 10184170 ns/iter (± 455895) 1.01
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 1812 ns/iter (± 30) 1828 ns/iter (± 22) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=0 1816 ns/iter (± 3) 1834 ns/iter (± 12) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2 1821 ns/iter (± 5) 1846 ns/iter (± 12) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=32 1822 ns/iter (± 4) 1818 ns/iter (± 8) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2048 1795 ns/iter (± 14) 1833 ns/iter (± 6) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/default 1856 ns/iter (± 20) 1821 ns/iter (± 21) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=0 1821 ns/iter (± 9) 1843 ns/iter (± 15) 0.99
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2 1834 ns/iter (± 9) 1824 ns/iter (± 17) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=32 1821 ns/iter (± 8) 1847 ns/iter (± 5) 0.99
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2048 1818 ns/iter (± 2) 1838 ns/iter (± 20) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 280 ns/iter (± 0) 280 ns/iter (± 1) 1
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 447 ns/iter (± 3) 437 ns/iter (± 1) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=0 279 ns/iter (± 1) 279 ns/iter (± 1) 1
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=0 456 ns/iter (± 0) 443 ns/iter (± 1) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2 279 ns/iter (± 0) 280 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2 456 ns/iter (± 1) 444 ns/iter (± 1) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=32 280 ns/iter (± 1) 281 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=32 453 ns/iter (± 2) 439 ns/iter (± 3) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2048 280 ns/iter (± 1) 279 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2048 448 ns/iter (± 0) 435 ns/iter (± 2) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/default 280 ns/iter (± 0) 279 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/default 448 ns/iter (± 1) 434 ns/iter (± 1) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=0 279 ns/iter (± 1) 279 ns/iter (± 0) 1
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=0 457 ns/iter (± 1) 447 ns/iter (± 3) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2 279 ns/iter (± 0) 278 ns/iter (± 1) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2 456 ns/iter (± 0) 449 ns/iter (± 0) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=32 279 ns/iter (± 0) 279 ns/iter (± 0) 1
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=32 453 ns/iter (± 1) 439 ns/iter (± 0) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2048 280 ns/iter (± 0) 280 ns/iter (± 1) 1
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2048 449 ns/iter (± 1) 434 ns/iter (± 1) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 11778877 ns/iter (± 610053) 12174288 ns/iter (± 597918) 0.97
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=0 2136426 ns/iter (± 48620) 2181647 ns/iter (± 27486) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2 2170658 ns/iter (± 38729) 2186675 ns/iter (± 14860) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=32 1903331 ns/iter (± 16228) 1936760 ns/iter (± 12398) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2048 1877590 ns/iter (± 12669) 1840328 ns/iter (± 16573) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/range/default 11004296 ns/iter (± 398845) 11722311 ns/iter (± 742657) 0.94
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=0 2189262 ns/iter (± 11634) 2130938 ns/iter (± 71721) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2 2144118 ns/iter (± 10726) 2154847 ns/iter (± 17490) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=32 1834324 ns/iter (± 6430) 1884472 ns/iter (± 28531) 0.97
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2048 1813853 ns/iter (± 9775) 1830844 ns/iter (± 28354) 0.99
vector_ops/sort/instances=10000/smallvec/n=4 12497 ns/iter (± 32) 12359 ns/iter (± 25) 1.01
vector_ops/sort/instances=10000/tinyvec/n=4 9650 ns/iter (± 34) 9661 ns/iter (± 49) 1.00
vector_ops/sort/instances=10000/vec 9635 ns/iter (± 27) 9626 ns/iter (± 33) 1.00
vector_ops/split_off/instances=10000/smallvec/n=4/manual 5565 ns/iter (± 63) 5561 ns/iter (± 19) 1.00
vector_ops/split_off/instances=10000/tinyvec/n=4 2732 ns/iter (± 24) 2740 ns/iter (± 27) 1.00
vector_ops/split_off/instances=10000/tinyvec/n=4/manual 2738 ns/iter (± 21) 2749 ns/iter (± 21) 1.00
vector_ops/split_off/instances=10000/vec 2724 ns/iter (± 26) 2731 ns/iter (± 21) 1.00
vector_ops/split_off/instances=10000/vec/manual 2722 ns/iter (± 22) 2735 ns/iter (± 17) 1.00
vector_ops/swap/instances=10000/smallvec/n=4 32785 ns/iter (± 40) 32763 ns/iter (± 60) 1.00
vector_ops/swap/instances=10000/tinyvec/n=4 18283 ns/iter (± 31) 18283 ns/iter (± 22) 1
vector_ops/swap/instances=10000/vec 12315 ns/iter (± 37) 12319 ns/iter (± 47) 1.00
vector_ops/swap_opt/instances=10000/smallvec/n=4 42732 ns/iter (± 84) 42705 ns/iter (± 90) 1.00
vector_ops/swap_opt/instances=10000/tinyvec/n=4 28857 ns/iter (± 86) 28791 ns/iter (± 66) 1.00
vector_ops/swap_opt/instances=10000/vec 19772 ns/iter (± 253) 19818 ns/iter (± 25) 1.00
mono_points_arrow/generate_message_bundles 42762926 ns/iter (± 508447) 46316431 ns/iter (± 644918) 0.92
mono_points_arrow/generate_messages 164402629 ns/iter (± 1182345) 183382126 ns/iter (± 1497890) 0.90
mono_points_arrow/encode_log_msg 206750164 ns/iter (± 684762) 224379598 ns/iter (± 1031199) 0.92
mono_points_arrow/encode_total 410846829 ns/iter (± 1447485) 452302399 ns/iter (± 1815719) 0.91
mono_points_arrow/decode_log_msg 252734238 ns/iter (± 851442) 270391565 ns/iter (± 1237132) 0.93
mono_points_arrow/decode_message_bundles 86121104 ns/iter (± 897095) 99694109 ns/iter (± 1125172) 0.86
mono_points_arrow/decode_total 336645405 ns/iter (± 1593705) 368423831 ns/iter (± 2140655) 0.91
mono_points_arrow_batched/generate_message_bundles 35683368 ns/iter (± 1150670) 36718603 ns/iter (± 1354639) 0.97
mono_points_arrow_batched/generate_messages 9805754 ns/iter (± 554650) 11364244 ns/iter (± 674006) 0.86
mono_points_arrow_batched/encode_log_msg 1797258 ns/iter (± 7371) 1802197 ns/iter (± 4059) 1.00
mono_points_arrow_batched/encode_total 48791444 ns/iter (± 1138909) 51982074 ns/iter (± 4524698) 0.94
mono_points_arrow_batched/decode_log_msg 980324 ns/iter (± 2531) 991987 ns/iter (± 4324) 0.99
mono_points_arrow_batched/decode_message_bundles 18539368 ns/iter (± 701628) 20640513 ns/iter (± 1463771) 0.90
mono_points_arrow_batched/decode_total 20079367 ns/iter (± 571829) 21075346 ns/iter (± 1540303) 0.95
batch_points_arrow/generate_message_bundles 283926 ns/iter (± 1107) 284473 ns/iter (± 1995) 1.00
batch_points_arrow/generate_messages 7557 ns/iter (± 33) 7639 ns/iter (± 13) 0.99
batch_points_arrow/encode_log_msg 383926 ns/iter (± 2129) 394503 ns/iter (± 3369) 0.97
batch_points_arrow/encode_total 695311 ns/iter (± 2021) 695338 ns/iter (± 4884) 1.00
batch_points_arrow/decode_log_msg 338564 ns/iter (± 1066) 337876 ns/iter (± 1156) 1.00
batch_points_arrow/decode_message_bundles 2891 ns/iter (± 19) 2912 ns/iter (± 13) 0.99
batch_points_arrow/decode_total 348887 ns/iter (± 1435) 347168 ns/iter (± 3149) 1.00
arrow_mono_points/insert 6032616798 ns/iter (± 10393315) 6958829824 ns/iter (± 13837782) 0.87
arrow_mono_points/query 1807643 ns/iter (± 13133) 1812590 ns/iter (± 20101) 1.00
arrow_batch_points/insert 3033773 ns/iter (± 12081) 2970081 ns/iter (± 36870) 1.02
arrow_batch_points/query 16455 ns/iter (± 33) 16453 ns/iter (± 50) 1.00
arrow_batch_vecs/insert 42750 ns/iter (± 103) 42748 ns/iter (± 203) 1.00
arrow_batch_vecs/query 506201 ns/iter (± 1478) 506242 ns/iter (± 2723) 1.00
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.