First batch of unwrap()'s removed (mostly in re_types)

Cargo.toml

@@ -444,7 +444,7 @@ missing_errors_doc = "allow"
 # This would be nice to enable, but we have way too many unwraps right now 😭
 # Enabling this lint in 2023-04-27 yielded 556 hits.
 # Enabling this lint in 2023-09-23 yielded 352 hits
-unwrap_used = "allow"
+unwrap_used = "warn"
 
 [patch.crates-io]
 # Try to avoid patching crates! It prevents us from publishing the crates on crates.io.

crates/re_analytics/examples/end_to_end.rs

@@ -4,17 +4,17 @@ use re_analytics::Event;
 use re_analytics::Properties;
 use re_analytics::{Analytics, AnalyticsEvent};
 
-fn main() -> ! {
+fn main() -> Result<(), Box<dyn std::error::Error>> {
     re_log::setup_logging();
 
-    let analytics = Analytics::new(Duration::from_secs(3)).unwrap();
+    let analytics = Analytics::new(Duration::from_secs(3))?;
     let application_id = "end_to_end_example".to_owned();
     let recording_id = uuid::Uuid::new_v4().to_string();
 
     println!("any non-empty line written here will be sent as an analytics datapoint");
     loop {
         let mut input = String::new();
-        std::io::stdin().read_line(&mut input).unwrap();
+        std::io::stdin().read_line(&mut input)?;
 
         let input = input.trim();
         if !input.is_empty() {

crates/re_analytics/src/native/config.rs

@@ -106,7 +106,9 @@ impl Config {
     }
 
     pub fn config_dir(&self) -> &Path {
-        self.config_file_path.parent().unwrap()
+        self.config_file_path
+            .parent()
+            .expect("config file has no parent")
     }
 
     pub fn config_file(&self) -> &Path {

crates/re_build_info/src/build_info.rs

@@ -166,8 +166,8 @@ fn crate_version_from_build_info_string() {
 
     {
         let expected_crate_version = build_info.version;
-        let crate_version = CrateVersion::try_parse_from_build_info_string(build_info_str).unwrap();
+        let crate_version = CrateVersion::try_parse_from_build_info_string(build_info_str);
 
-        assert_eq!(expected_crate_version, crate_version);
+        assert_eq!(Ok(expected_crate_version), crate_version);
     }
 }

crates/re_build_tools/src/hashing.rs

@@ -12,7 +12,7 @@ use crate::{rerun_if_changed, rerun_if_changed_or_doesnt_exist};
 fn encode_hex(bytes: &[u8]) -> String {
     let mut s = String::with_capacity(bytes.len() * 2);
     for &b in bytes {
-        write!(&mut s, "{b:02x}").unwrap();
+        write!(&mut s, "{b:02x}").expect("writing to string should never fail");
     }
     s
 }

crates/re_data_store/benches/gc.rs

@@ -7,6 +7,7 @@ use itertools::Itertools;
 use re_data_store::{
     DataStore, DataStoreConfig, GarbageCollectionOptions, GarbageCollectionTarget,
 };
+use re_log::ResultExt;
 use re_log_types::{
     build_frame_nr, build_log_time, DataRow, DataTable, EntityPath, RowId, TableId, Time, TimePoint,
 };
@@ -156,8 +157,9 @@ where
     for _ in 0..NUM_ROWS_PER_ENTITY_PATH {
         #[allow(clippy::needless_range_loop)] // readability
         for i in 0..NUM_ENTITY_PATHS {
-            let row = rows_per_table[i].next().unwrap();
-            store.insert_row(&row.unwrap()).unwrap();
+            if let Some(Ok(row)) = rows_per_table[i].next() {
+                store.insert_row(&row).ok_or_log_error();
+            }
         }
     }
 
@@ -176,7 +178,7 @@ where
 {
     let mut table = DataTable::from_rows(
         TableId::ZERO,
-        (0..NUM_ROWS_PER_ENTITY_PATH).map(move |i| {
+        (0..NUM_ROWS_PER_ENTITY_PATH).filter_map(move |i| {
             DataRow::from_component_batches(
                 RowId::new(),
                 timegen(i),
@@ -186,14 +188,19 @@ where
                     .iter()
                     .map(|batch| batch as &dyn ComponentBatch),
             )
-            .unwrap()
+            .ok_or_log_error()
         }),
     );
 
     // Do a serialization roundtrip to pack everything in contiguous memory.
     if packed {
-        let (schema, columns) = table.serialize().unwrap();
-        table = DataTable::deserialize(TableId::ZERO, &schema, &columns).unwrap();
+        if let Some(t) = table
+            .serialize()
+            .and_then(|(schema, columns)| DataTable::deserialize(TableId::ZERO, &schema, &columns))
+            .ok_or_log_error()
+        {
+            table = t;
+        }
     }
 
     table.compute_all_size_bytes();

crates/re_types/Cargo.toml

@@ -15,7 +15,6 @@ version.workspace = true
 [lints]
 workspace = true
 
-
 [package.metadata.docs.rs]
 all-features = false
 no-default-features = true