disable size stats

rerun-io · Mar 30, 2023 · d49e5a1 · d49e5a1
1 parent e0a6914
commit d49e5a1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/crates/re_arrow_store/src/store_stats.rs b/crates/re_arrow_store/src/store_stats.rs
@@ -8,7 +8,7 @@ use crate::{
 
 // ---
 
-#[derive(Default, Debug)]
+#[derive(Default, Debug, Clone)]
 pub struct DataStoreStats {
     pub total_timeless_rows: u64,
     pub total_timeless_size_bytes: u64,
@@ -183,7 +183,7 @@ impl IndexedBucket {
             col_insert_id,
             col_row_id,
             col_num_instances,
-            columns,
+            columns: _,
         } = &*inner.read();
 
         let control_size_bytes = std::mem::size_of_val(is_sorted)
@@ -193,7 +193,9 @@ impl IndexedBucket {
             + std::mem::size_of_val(col_row_id.as_slice())
             + std::mem::size_of_val(col_num_instances.as_slice());
 
-        let data_size_bytes = compute_columns_size_bytes(columns);
+        // TODO(#1738): computing size stats is insanely slow.
+        // let data_size_bytes = compute_columns_size_bytes(columns);
+        let data_size_bytes = 0;
 
         control_size_bytes as u64 + data_size_bytes
     }
@@ -222,7 +224,7 @@ impl PersistentIndexedTable {
             col_insert_id,
             col_row_id,
             col_num_instances,
-            columns,
+            columns: _,
         } = self;
 
         let control_size_bytes = std::mem::size_of_val(ent_path)
@@ -231,7 +233,9 @@ impl PersistentIndexedTable {
             + std::mem::size_of_val(col_row_id.as_slice())
             + std::mem::size_of_val(col_num_instances.as_slice());
 
-        let data_size_bytes = compute_columns_size_bytes(columns);
+        // TODO(#1738): computing size stats is insanely slow.
+        // let data_size_bytes = compute_columns_size_bytes(columns);
+        let data_size_bytes = 0;
 
         control_size_bytes as u64 + data_size_bytes
     }
@@ -242,6 +246,7 @@ impl PersistentIndexedTable {
 /// Computes the size in bytes of an entire table's worth of data.
 ///
 /// Beware: this is costly!
+#[allow(dead_code)]
 fn compute_columns_size_bytes(columns: &IntMap<ComponentName, DataCellColumn>) -> u64 {
     let keys = (columns.keys().len() * std::mem::size_of::<ComponentName>()) as u64;
     let cells = columns

diff --git a/crates/re_viewer/src/ui/memory_panel.rs b/crates/re_viewer/src/ui/memory_panel.rs
@@ -186,7 +186,6 @@ impl MemoryPanel {
 
                 ui.label(egui::RichText::new("Limits").italics());
                 ui.label("Row limit");
-                ui.label("Size limit");
                 ui.end_row();
 
                 let label_rows = |ui: &mut egui::Ui, num_rows| {
@@ -197,7 +196,11 @@ impl MemoryPanel {
                     }
                 };
 
-                ui.label("Indices:");
+                ui.label("Timeless:");
+                label_rows(ui, u64::MAX);
+                ui.end_row();
+
+                ui.label("Temporal:");
                 label_rows(ui, config.indexed_bucket_num_rows);
                 ui.end_row();
             });