Skip to content

Commit

Permalink
Fix remove tooltip between entities and groups being swapped. (#1637)
Browse files Browse the repository at this point in the history 
Fixes #1261
  • Loading branch information
@Wumpf
Wumpf authored Mar 21, 2023
1 parent a01f436 commit c7b8095
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/re_viewer/src/ui/viewport.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ impl Viewport {
}
if re_ui
.small_icon_button(ui, &re_ui::icons::REMOVE)
.on_hover_text("Remove group and all its children from the space view.")
.on_hover_text("Remove Entity from the space view.")
.clicked()
{
space_view.data_blueprint.remove_entity(entity_path);
Expand Down Expand Up @@ -295,7 +295,7 @@ impl Viewport {
);
if re_ui
.small_icon_button(ui, &re_ui::icons::REMOVE)
.on_hover_text("Remove Entity from the space view.")
.on_hover_text("Remove group and all its children from the space view.")
.clicked()
{
remove_group = true;
Expand Down

1 comment on commit c7b8095

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: c7b8095 Previous: a01f436 Ratio
datastore/insert/batch/rects/insert 604695 ns/iter (± 28512) 561892 ns/iter (± 1674) 1.08
datastore/latest_at/batch/rects/query 1878 ns/iter (± 4) 1860 ns/iter (± 4) 1.01
datastore/latest_at/missing_components/primary 288 ns/iter (± 0) 287 ns/iter (± 0) 1.00
datastore/latest_at/missing_components/secondaries 437 ns/iter (± 0) 439 ns/iter (± 0) 1.00
datastore/range/batch/rects/query 154046 ns/iter (± 560) 154126 ns/iter (± 237) 1.00
mono_points_arrow/generate_message_bundles 52622948 ns/iter (± 635994) 48641308 ns/iter (± 556597) 1.08
mono_points_arrow/generate_messages 142193374 ns/iter (± 1431202) 129249567 ns/iter (± 1294841) 1.10
mono_points_arrow/encode_log_msg 168932722 ns/iter (± 918965) 161748727 ns/iter (± 2105004) 1.04
mono_points_arrow/encode_total 367815123 ns/iter (± 1740258) 341196465 ns/iter (± 1562213) 1.08
mono_points_arrow/decode_log_msg 191834169 ns/iter (± 920580) 180264566 ns/iter (± 965868) 1.06
mono_points_arrow/decode_message_bundles 77293822 ns/iter (± 1052807) 66623053 ns/iter (± 903049) 1.16
mono_points_arrow/decode_total 266428918 ns/iter (± 1880498) 244317227 ns/iter (± 1488236) 1.09
batch_points_arrow/generate_message_bundles 329089 ns/iter (± 495) 327866 ns/iter (± 424) 1.00
batch_points_arrow/generate_messages 6438 ns/iter (± 20) 6594 ns/iter (± 25) 0.98
batch_points_arrow/encode_log_msg 403928 ns/iter (± 1533) 358793 ns/iter (± 1808) 1.13
batch_points_arrow/encode_total 750170 ns/iter (± 17411) 707391 ns/iter (± 2541) 1.06
batch_points_arrow/decode_log_msg 383163 ns/iter (± 1462) 350632 ns/iter (± 2283) 1.09
batch_points_arrow/decode_message_bundles 2071 ns/iter (± 19) 2042 ns/iter (± 10) 1.01
batch_points_arrow/decode_total 385467 ns/iter (± 1141) 357179 ns/iter (± 1428) 1.08
arrow_mono_points/insert 7255726121 ns/iter (± 30054667) 7964927347 ns/iter (± 48463190) 0.91
arrow_mono_points/query 1892324 ns/iter (± 24367) 1782963 ns/iter (± 29052) 1.06
arrow_batch_points/insert 2822287 ns/iter (± 12027) 2702043 ns/iter (± 34656) 1.04
arrow_batch_points/query 16121 ns/iter (± 15) 16196 ns/iter (± 30) 1.00
arrow_batch_vecs/insert 45982 ns/iter (± 121) 41950 ns/iter (± 153) 1.10
arrow_batch_vecs/query 408594 ns/iter (± 1494) 389236 ns/iter (± 1835) 1.05
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.