Skip to content

Commit

Permalink
impl Copy for Arrow3D. (#2239)
Browse files Browse the repository at this point in the history
### What

`Arrow3D` is a simple pair of vectors, so it should be `Copy` like
vectors are. This will ease working with, for example, batches of arrows
stored in arrays.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] ~~I've included a screenshot or gif (if applicable)~~

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: {{ pr-build-summary }}
  • Loading branch information
kpreid authored May 29, 2023
1 parent 9fdc1a9 commit c4373c6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/re_log_types/src/component_types/arrow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use crate::Component;
/// ])
/// );
/// ```
#[derive(Clone, Debug, ArrowField, ArrowSerialize, ArrowDeserialize, PartialEq)]
#[derive(Copy, Clone, Debug, ArrowField, ArrowSerialize, ArrowDeserialize, PartialEq)]
#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
pub struct Arrow3D {
pub origin: Vec3D,
Expand Down

1 comment on commit c4373c6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.

Benchmark suite Current: c4373c6 Previous: 9fdc1a9 Ratio
batch_points_arrow/encode_log_msg 118118 ns/iter (± 398) 93710 ns/iter (± 1213) 1.26

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.