Skip to content

Commit

Permalink
Don't assert if inserting a rowid with a matching timepoint does not …
Browse files Browse the repository at this point in the history 
…create a conflict (#1832)
  • Loading branch information
@jleibs
jleibs authored Apr 12, 2023
1 parent d2d83d7 commit c181adf
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions crates/re_arrow_store/src/store_write.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,10 @@ impl MetadataRegistry<TimePoint> {
let entry = entry.get_mut();
for (timeline, time) in timepoint {
if let Some(old_time) = entry.insert(timeline, time) {
re_log::error!(%row_id, ?timeline, old_time = ?old_time, new_time = ?time, "detected re-used `RowId/Timeline` pair, this is illegal and will lead to undefined behavior in the datastore");
debug_assert!(false, "detected re-used `RowId/Timeline`");
if old_time != time {
re_log::error!(%row_id, ?timeline, old_time = ?old_time, new_time = ?time, "detected re-used `RowId/Timeline` pair, this is illegal and will lead to undefined behavior in the datastore");
debug_assert!(false, "detected re-used `RowId/Timeline`");
}
}
}
}
Expand Down

1 comment on commit c181adf

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: c181adf Previous: d2d83d7 Ratio
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 3125498 ns/iter (± 145512) 2790797 ns/iter (± 41581) 1.12
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 372 ns/iter (± 2) 373 ns/iter (± 2) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 263 ns/iter (± 0) 262 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 422 ns/iter (± 0) 420 ns/iter (± 5) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 3382024 ns/iter (± 192764) 2978113 ns/iter (± 25197) 1.14
datastore/num_rows=1000/num_instances=1000/gc/default 2369600 ns/iter (± 5481) 2413513 ns/iter (± 5884) 0.98
mono_points_arrow/generate_message_bundles 29698676 ns/iter (± 279994) 25726375 ns/iter (± 932039) 1.15
mono_points_arrow/generate_messages 113720829 ns/iter (± 890354) 112427686 ns/iter (± 837395) 1.01
mono_points_arrow/encode_log_msg 150101699 ns/iter (± 1563246) 142388716 ns/iter (± 646306) 1.05
mono_points_arrow/encode_total 292483106 ns/iter (± 1705042) 282427094 ns/iter (± 1187569) 1.04
mono_points_arrow/decode_log_msg 182534083 ns/iter (± 810543) 178620882 ns/iter (± 739975) 1.02
mono_points_arrow/decode_message_bundles 60847389 ns/iter (± 486272) 59931903 ns/iter (± 591274) 1.02
mono_points_arrow/decode_total 240028503 ns/iter (± 1284211) 236964115 ns/iter (± 1008520) 1.01
mono_points_arrow_batched/generate_message_bundles 26736450 ns/iter (± 709437) 18990354 ns/iter (± 1114928) 1.41
mono_points_arrow_batched/generate_messages 5249672 ns/iter (± 397742) 4000736 ns/iter (± 100362) 1.31
mono_points_arrow_batched/encode_log_msg 1348413 ns/iter (± 8422) 1336436 ns/iter (± 17173) 1.01
mono_points_arrow_batched/encode_total 31409540 ns/iter (± 1124532) 25717364 ns/iter (± 983419) 1.22
mono_points_arrow_batched/decode_log_msg 786259 ns/iter (± 5861) 779306 ns/iter (± 1948) 1.01
mono_points_arrow_batched/decode_message_bundles 9377300 ns/iter (± 782105) 7632740 ns/iter (± 97030) 1.23
mono_points_arrow_batched/decode_total 10624050 ns/iter (± 392215) 8444072 ns/iter (± 98841) 1.26
batch_points_arrow/generate_message_bundles 240025 ns/iter (± 279) 238585 ns/iter (± 989) 1.01
batch_points_arrow/generate_messages 5066 ns/iter (± 17) 5069 ns/iter (± 24) 1.00
batch_points_arrow/encode_log_msg 263135 ns/iter (± 1446) 257073 ns/iter (± 914) 1.02
batch_points_arrow/encode_total 539918 ns/iter (± 5294) 533687 ns/iter (± 2049) 1.01
batch_points_arrow/decode_log_msg 215683 ns/iter (± 1409) 214398 ns/iter (± 801) 1.01
batch_points_arrow/decode_message_bundles 1882 ns/iter (± 3) 1873 ns/iter (± 16) 1.00
batch_points_arrow/decode_total 225505 ns/iter (± 1626) 222809 ns/iter (± 1091) 1.01
arrow_mono_points/insert 2302394099 ns/iter (± 5295173) 2303921887 ns/iter (± 6992349) 1.00
arrow_mono_points/query 1620314 ns/iter (± 25698) 1586263 ns/iter (± 11199) 1.02
arrow_batch_points/insert 1148503 ns/iter (± 2331) 1143017 ns/iter (± 19149) 1.00
arrow_batch_points/query 16775 ns/iter (± 29) 16862 ns/iter (± 35) 0.99
arrow_batch_vecs/insert 26788 ns/iter (± 71) 26353 ns/iter (± 97) 1.02
arrow_batch_vecs/query 389964 ns/iter (± 1225) 388655 ns/iter (± 1585) 1.00
tuid/Tuid::random 35 ns/iter (± 0) 34 ns/iter (± 0) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.