Skip to content

Commit

Permalink
Always upload latest prerelease to a dedicated prefix (#1676)
Browse files Browse the repository at this point in the history 
* Make the short sha 7 characters instead of 8 to match github
* Always upload latest prerelease to a dedicated prefix
  • Loading branch information
@jleibs
jleibs authored Mar 22, 2023
1 parent 89c04bf commit a935603
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/python.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ jobs:
service_account: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }}

- name: Add SHORT_SHA env property with commit short sha
run: echo "SHORT_SHA=`echo ${{github.sha}} | cut -c1-8`" >> $GITHUB_ENV
run: echo "SHORT_SHA=`echo ${{github.sha}} | cut -c1-7`" >> $GITHUB_ENV

- name: "Upload RRD"
uses: google-github-actions/upload-cloud-storage@v1
Expand All @@ -295,6 +295,14 @@ jobs:
destination: "rerun-example-rrd/commit/${{env.SHORT_SHA}}"
parent: false

- name: "Upload RRD (prerelease)"
if: github.ref == 'refs/heads/main'
uses: google-github-actions/upload-cloud-storage@v1
with:
path: "rrd"
destination: "rerun-example-rrd/prerelease"
parent: false

- name: "Upload RRD (tagged)"
if: startsWith(github.ref, 'refs/tags/v')
uses: google-github-actions/upload-cloud-storage@v1
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/rust.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ jobs:
service_account: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }}

- name: Add SHORT_SHA env property with commit short sha
run: echo "SHORT_SHA=`echo ${{github.sha}} | cut -c1-8`" >> $GITHUB_ENV
run: echo "SHORT_SHA=`echo ${{github.sha}} | cut -c1-7`" >> $GITHUB_ENV

- name: "Upload web-viewer"
uses: google-github-actions/upload-cloud-storage@v1
Expand All @@ -291,6 +291,14 @@ jobs:
destination: "rerun-web-viewer/commit/${{env.SHORT_SHA}}"
parent: false

- name: "Upload web-viewer (prerelease)"
if: github.ref == 'refs/heads/main'
uses: google-github-actions/upload-cloud-storage@v1
with:
path: "web_viewer"
destination: "rerun-web-viewer/prerelease"
parent: false

- name: "Upload web-viewer (tagged)"
if: startsWith(github.ref, 'refs/tags/v')
uses: google-github-actions/upload-cloud-storage@v1
Expand Down

1 comment on commit a935603

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: a935603 Previous: 89c04bf Ratio
datastore/insert/batch/rects/insert 583176 ns/iter (± 2731) 555766 ns/iter (± 5774) 1.05
datastore/latest_at/batch/rects/query 1875 ns/iter (± 29) 1876 ns/iter (± 2) 1.00
datastore/latest_at/missing_components/primary 294 ns/iter (± 0) 287 ns/iter (± 22) 1.02
datastore/latest_at/missing_components/secondaries 445 ns/iter (± 9) 438 ns/iter (± 2) 1.02
datastore/range/batch/rects/query 160349 ns/iter (± 3100) 150647 ns/iter (± 424) 1.06
mono_points_arrow/generate_message_bundles 55423760 ns/iter (± 961151) 48408969 ns/iter (± 434736) 1.14
mono_points_arrow/generate_messages 143700909 ns/iter (± 1638179) 126285462 ns/iter (± 1153936) 1.14
mono_points_arrow/encode_log_msg 174373812 ns/iter (± 3331921) 156330591 ns/iter (± 692221) 1.12
mono_points_arrow/encode_total 371262329 ns/iter (± 7732549) 330002220 ns/iter (± 1479570) 1.13
mono_points_arrow/decode_log_msg 194074286 ns/iter (± 7421825) 175760006 ns/iter (± 1100190) 1.10
mono_points_arrow/decode_message_bundles 81146250 ns/iter (± 1845871) 64245807 ns/iter (± 844043) 1.26
mono_points_arrow/decode_total 268331743 ns/iter (± 3761224) 237296619 ns/iter (± 1552605) 1.13
batch_points_arrow/generate_message_bundles 340117 ns/iter (± 731) 337530 ns/iter (± 654) 1.01
batch_points_arrow/generate_messages 6385 ns/iter (± 20) 6347 ns/iter (± 12) 1.01
batch_points_arrow/encode_log_msg 379875 ns/iter (± 2262) 362815 ns/iter (± 647) 1.05
batch_points_arrow/encode_total 747519 ns/iter (± 5763) 724112 ns/iter (± 2794) 1.03
batch_points_arrow/decode_log_msg 358896 ns/iter (± 5735) 346319 ns/iter (± 788) 1.04
batch_points_arrow/decode_message_bundles 2074 ns/iter (± 7) 2068 ns/iter (± 10) 1.00
batch_points_arrow/decode_total 373219 ns/iter (± 5154) 350544 ns/iter (± 1230) 1.06
arrow_mono_points/insert 7799874241 ns/iter (± 125428756) 6021883606 ns/iter (± 33210826) 1.30
arrow_mono_points/query 1936298 ns/iter (± 80846) 1794718 ns/iter (± 9991) 1.08
arrow_batch_points/insert 2870483 ns/iter (± 243918) 2610469 ns/iter (± 6805) 1.10
arrow_batch_points/query 16168 ns/iter (± 38) 16179 ns/iter (± 54) 1.00
arrow_batch_vecs/insert 42894 ns/iter (± 195) 42535 ns/iter (± 165) 1.01
arrow_batch_vecs/query 389632 ns/iter (± 687) 388927 ns/iter (± 346) 1.00
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.