Skip to content

Commit

Permalink
Flush before generating the html (#2073)
Browse files Browse the repository at this point in the history
* Flush before generating the html

* Link to PR for recording handle
  • Loading branch information
jleibs authored and jprochazk committed May 11, 2023
1 parent 9eebb86 commit 9c0c4f5
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions rerun_py/rerun_sdk/rerun/recording.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ def as_html(
# Use a random presentation ID to avoid collisions when multiple recordings are shown in the same notebook.
presentation_id = "".join(random.choice(string.ascii_letters) for i in range(6))

# TODO(#1903): flush the specific recording instead of all recordings
# This is more evidence we we want this to be a handle to the stream and not just
# the storage.
bindings.flush()

base64_data = base64.b64encode(self.storage.get_rrd_as_bytes()).decode("utf-8")

html_template = f"""
Expand Down

0 comments on commit 9c0c4f5

Please sign in to comment.