Skip to content

Commit

Permalink
setup_dev.sh now installs pngcrush (#2470)
Browse files Browse the repository at this point in the history
### What

`setup_dev.sh` now installs pngcrush, which is needed by the
`upload_image.py`/`just upload` script.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] ~~I've included a screenshot or gif (if applicable)~~ 

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2470

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/63a7dff/docs
Examples preview: https://rerun.io/preview/63a7dff/examples
<!-- pr-link-docs:end -->
  • Loading branch information
abey79 authored Jun 19, 2023
1 parent 1c6f981 commit 907c80d
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions scripts/setup_dev.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,19 @@ cargo install just # Just a command runner
cargo install taplo-cli --locked # toml formatter/linter/lsp
cargo install typos-cli


packagesNeeded='pngcrush'
if [ -x "$(command -v brew)" ]; then brew install $packagesNeeded
elif [ -x "$(command -v port)" ]; then sudo port install $packagesNeeded
elif [ -x "$(command -v apt-get)" ]; then sudo apt-get -y install $packagesNeeded
elif [ -x "$(command -v dnf)" ]; then sudo dnf install $packagesNeeded
elif [ -x "$(command -v zypper)" ]; then sudo zypper install $packagesNeeded
elif [ -x "$(command -v apk)" ]; then sudo apk add --no-cache $packagesNeeded
elif [ -x "$(command -v winget)" ]; then sudo winget add --no-cache $packagesNeeded
elif [ -x "$(command -v pacman)" ]; then sudo pacman -S $packagesNeeded
else
echo "FAILED TO INSTALL PACKAGE: Package manager not found. You must manually install: $packagesNeeded">&2;
exit 1
fi

echo "setup_dev.sh completed!"

1 comment on commit 907c80d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.

Benchmark suite Current: 907c80d Previous: 1c6f981 Ratio
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 3868517 ns/iter (± 48464) 2863729 ns/iter (± 10577) 1.35
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 390 ns/iter (± 5) 311 ns/iter (± 2) 1.25
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 290 ns/iter (± 4) 228 ns/iter (± 0) 1.27
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 437 ns/iter (± 5) 342 ns/iter (± 3) 1.28
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 3906218 ns/iter (± 44900) 2936346 ns/iter (± 5616) 1.33
datastore/num_rows=1000/num_instances=1000/gc/default 2543826 ns/iter (± 28630) 1710370 ns/iter (± 2420) 1.49
mono_points_arrow_batched/generate_messages 5122219 ns/iter (± 91027) 3607985 ns/iter (± 16020) 1.42
mono_points_arrow_batched/encode_log_msg 657384 ns/iter (± 7058) 513774 ns/iter (± 1125) 1.28
batch_points_arrow/decode_total 53742 ns/iter (± 472) 42281 ns/iter (± 114) 1.27
arrow_mono_points/insert 2617036016 ns/iter (± 12091714) 1805529784 ns/iter (± 24277918) 1.45
arrow_mono_points/query 1290975 ns/iter (± 15596) 1031242 ns/iter (± 9255) 1.25
arrow_batch_vecs/query 454579 ns/iter (± 5233) 316347 ns/iter (± 405) 1.44

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.