Skip to content

Commit

Permalink
Fix scripts/lint.py to ignore .nox (#2580)
Browse files Browse the repository at this point in the history 
### What

Adds `.nox` in the list of ignored directories for `scripts/lint.py`.
This is created by nox, introduced in #2536.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2580) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2580)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Ffix-lint.py/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Ffix-lint.py/examples)
  • Loading branch information
@abey79
abey79 authored Jul 1, 2023
1 parent 9492e87 commit 7b12442
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/lint.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ def main() -> None:

extensions = ["fbs", "html", "js", "md", "py", "rs", "sh", "toml", "wgsl", "yml"]

exclude_dirs = {"env", "renv", "venv", "target", "target_ra", "target_wasm"}
exclude_dirs = {"env", "renv", "venv", "target", "target_ra", "target_wasm", ".nox"}

exclude_paths = {
"./CODE_STYLE.md",
Expand Down

1 comment on commit 7b12442

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.

Benchmark suite Current: 7b12442 Previous: 9492e87 Ratio
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 3799544 ns/iter (± 73467) 2902664 ns/iter (± 8506) 1.31
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 404 ns/iter (± 1) 307 ns/iter (± 2) 1.32
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 298 ns/iter (± 0) 221 ns/iter (± 1) 1.35
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 452 ns/iter (± 2) 345 ns/iter (± 0) 1.31
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 3855863 ns/iter (± 72449) 2876357 ns/iter (± 5970) 1.34
datastore/num_rows=1000/num_instances=1000/gc/default 2689272 ns/iter (± 15831) 1707255 ns/iter (± 4452) 1.58
mono_points_arrow/generate_message_bundles 38372478 ns/iter (± 744110) 29641240 ns/iter (± 992413) 1.29
mono_points_arrow/encode_log_msg 234112574 ns/iter (± 762814) 178407237 ns/iter (± 1275738) 1.31
mono_points_arrow/decode_message_bundles 85802195 ns/iter (± 757664) 62395563 ns/iter (± 1748985) 1.38
mono_points_arrow_batched/generate_message_bundles 26316246 ns/iter (± 1436438) 18636834 ns/iter (± 453956) 1.41
mono_points_arrow_batched/generate_messages 5883915 ns/iter (± 222032) 3704382 ns/iter (± 56344) 1.59
mono_points_arrow_batched/encode_log_msg 781979 ns/iter (± 4772) 429126 ns/iter (± 1073) 1.82
mono_points_arrow_batched/encode_total 33857217 ns/iter (± 1328709) 23426946 ns/iter (± 467024) 1.45
mono_points_arrow_batched/decode_log_msg 568298 ns/iter (± 1933) 404805 ns/iter (± 941) 1.40
mono_points_arrow_batched/decode_message_bundles 10040503 ns/iter (± 164918) 7478007 ns/iter (± 18093) 1.34
mono_points_arrow_batched/decode_total 10885314 ns/iter (± 247502) 7900017 ns/iter (± 38485) 1.38
batch_points_arrow/encode_log_msg 92025 ns/iter (± 582) 49955 ns/iter (± 235) 1.84
batch_points_arrow/encode_total 344997 ns/iter (± 1251) 251684 ns/iter (± 471) 1.37
batch_points_arrow/decode_log_msg 50397 ns/iter (± 224) 37936 ns/iter (± 113) 1.33
batch_points_arrow/decode_total 57187 ns/iter (± 607) 41952 ns/iter (± 111) 1.36
arrow_mono_points/insert 2979068589 ns/iter (± 19871026) 1814599759 ns/iter (± 7117612) 1.64
arrow_mono_points/query 1430204 ns/iter (± 10631) 936007 ns/iter (± 1222) 1.53
arrow_batch_points/insert 1541874 ns/iter (± 4669) 1212115 ns/iter (± 4928) 1.27
arrow_batch_vecs/insert 36173 ns/iter (± 99) 24138 ns/iter (± 108) 1.50
arrow_batch_vecs/query 382287 ns/iter (± 963) 302508 ns/iter (± 789) 1.26

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.