Skip to content

Commit

Permalink
fix incorrect propagation of field's nullability
Browse files Browse the repository at this point in the history
  • Loading branch information
teh-cmc committed Sep 18, 2023
1 parent de31501 commit 36aa2d2
Show file tree
Hide file tree
Showing 25 changed files with 91 additions and 74 deletions.
2 changes: 1 addition & 1 deletion crates/re_types/source_hash.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer1.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer11.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer13.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer17.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer18.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer2.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer3.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer4.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer5.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer6.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer7.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions crates/re_types/src/testing/datatypes/affix_fuzzer1.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions crates/re_types/src/testing/datatypes/affix_fuzzer4.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions crates/re_types_builder/src/arrow_registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,23 @@ impl ArrowRegistry {
Box::new(LazyField {
name: "item".into(),
datatype: self.arrow_datatype_from_element_type(elem_type),
is_nullable: field.is_nullable,
// NOTE: Do _not_ confuse this with the nullability of the field itself!
// This would be the nullability of the elements of the list itself, which our IDL
// literally is unable to express at the moment, so you can be certain this is
// always false.
is_nullable: false,
metadata: Default::default(),
}),
length,
),
Type::Vector { elem_type } => LazyDatatype::List(Box::new(LazyField {
name: "item".into(),
datatype: self.arrow_datatype_from_element_type(elem_type),
is_nullable: field.is_nullable,
// NOTE: Do _not_ confuse this with the nullability of the field itself!
// This would be the nullability of the elements of the list itself, which our IDL
// literally is unable to express at the moment, so you can be certain this is
// always false.
is_nullable: false,
metadata: Default::default(),
})),
Type::Object(fqname) => LazyDatatype::Unresolved(fqname),
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rerun_py/rerun_sdk/rerun/_rerun2/components/affix_fuzzer16.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 36aa2d2

Please sign in to comment.