fix web feature name in error messages (#1521)

* fix web feature name * fmt
rerun-io · Mar 7, 2023 · 3566bc9 · 3566bc9 · github-actions · Mar 7, 2023
1 parent d7b6530
commit 3566bc9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/crates/rerun/src/run.rs b/crates/rerun/src/run.rs
@@ -46,7 +46,7 @@ struct Args {
     port: u16,
 
     /// Start the viewer in the browser (instead of locally).
-    /// Requires Rerun to have been compiled with the 'web' feature.
+    /// Requires Rerun to have been compiled with the 'web_viewer' feature.
     #[clap(long)]
     web_viewer: bool,
 
@@ -321,7 +321,9 @@ async fn run_impl(
         #[cfg(not(feature = "web_viewer"))]
         {
             _ = (call_source, rx);
-            anyhow::bail!("Can't host web-viewer - rerun was not compiled with the 'web' feature");
+            anyhow::bail!(
+                "Can't host web-viewer - rerun was not compiled with the 'web_viewer' feature"
+            );
         }
     } else {
         #[cfg(feature = "native_viewer")]
@@ -415,7 +417,7 @@ async fn host_web_viewer(rerun_ws_server_url: String) -> anyhow::Result<()> {
 
 #[cfg(not(feature = "web_viewer"))]
 async fn host_web_viewer(_rerun_ws_server_url: String) -> anyhow::Result<()> {
-    panic!("Can't host web-viewer - rerun was not compiled with the 'web' feature");
+    panic!("Can't host web-viewer - rerun was not compiled with the 'web_viewer' feature");
 }
 
 #[cfg(feature = "server")]

diff --git a/rerun_py/src/python_bridge.rs b/rerun_py/src/python_bridge.rs
@@ -301,7 +301,7 @@ fn serve(open_browser: bool) -> PyResult<()> {
     {
         _ = open_browser;
         Err(PyRuntimeError::new_err(
-            "The Rerun SDK was not compiled with the 'web' feature",
+            "The Rerun SDK was not compiled with the 'web_viewer' feature",
         ))
     }
 }
Benchmark suite	Current: `3566bc9`	Previous: `d7b6530`	Ratio
`datastore/insert/batch/rects/insert`	`569760` ns/iter (`± 1546`)	`554962` ns/iter (`± 14750`)	`1.03`
`datastore/latest_at/batch/rects/query`	`1834` ns/iter (`± 6`)	`1790` ns/iter (`± 6`)	`1.02`
`datastore/latest_at/missing_components/primary`	`356` ns/iter (`± 0`)	`356` ns/iter (`± 28`)	`1`
`datastore/latest_at/missing_components/secondaries`	`424` ns/iter (`± 0`)	`424` ns/iter (`± 0`)	`1`
`datastore/range/batch/rects/query`	`152397` ns/iter (`± 1034`)	`151268` ns/iter (`± 735`)	`1.01`
`mono_points_arrow/generate_message_bundles`	`47256558` ns/iter (`± 2247821`)	`49335491` ns/iter (`± 468720`)	`0.96`
`mono_points_arrow/generate_messages`	`135727445` ns/iter (`± 1444320`)	`125581867` ns/iter (`± 1151867`)	`1.08`
`mono_points_arrow/encode_log_msg`	`162301693` ns/iter (`± 1109711`)	`159414262` ns/iter (`± 1311026`)	`1.02`
`mono_points_arrow/encode_total`	`356535649` ns/iter (`± 2769285`)	`333443350` ns/iter (`± 2873169`)	`1.07`
`mono_points_arrow/decode_log_msg`	`187495689` ns/iter (`± 1436995`)	`178723918` ns/iter (`± 912871`)	`1.05`
`mono_points_arrow/decode_message_bundles`	`73411515` ns/iter (`± 1749534`)	`66234191` ns/iter (`± 725079`)	`1.11`
`mono_points_arrow/decode_total`	`256881167` ns/iter (`± 2420392`)	`241271712` ns/iter (`± 1394508`)	`1.06`
`batch_points_arrow/generate_message_bundles`	`321388` ns/iter (`± 1248`)	`323004` ns/iter (`± 851`)	`0.99`
`batch_points_arrow/generate_messages`	`6149` ns/iter (`± 22`)	`6137` ns/iter (`± 15`)	`1.00`
`batch_points_arrow/encode_log_msg`	`362493` ns/iter (`± 891`)	`369907` ns/iter (`± 1496`)	`0.98`
`batch_points_arrow/encode_total`	`711563` ns/iter (`± 1489`)	`721352` ns/iter (`± 2070`)	`0.99`
`batch_points_arrow/decode_log_msg`	`344494` ns/iter (`± 452`)	`350166` ns/iter (`± 1514`)	`0.98`
`batch_points_arrow/decode_message_bundles`	`2091` ns/iter (`± 3`)	`2089` ns/iter (`± 6`)	`1.00`
`batch_points_arrow/decode_total`	`353896` ns/iter (`± 614`)	`353211` ns/iter (`± 1380`)	`1.00`
`arrow_mono_points/insert`	`7063331625` ns/iter (`± 19469410`)	`6178245611` ns/iter (`± 22633370`)	`1.14`
`arrow_mono_points/query`	`1700222` ns/iter (`± 7217`)	`1756555` ns/iter (`± 17781`)	`0.97`
`arrow_batch_points/insert`	`2638085` ns/iter (`± 7255`)	`2702352` ns/iter (`± 54272`)	`0.98`
`arrow_batch_points/query`	`16937` ns/iter (`± 23`)	`16945` ns/iter (`± 80`)	`1.00`
`arrow_batch_vecs/insert`	`42421` ns/iter (`± 85`)	`43435` ns/iter (`± 165`)	`0.98`
`arrow_batch_vecs/query`	`388664` ns/iter (`± 387`)	`392640` ns/iter (`± 367`)	`0.99`
`tuid/Tuid::random`	`34` ns/iter (`± 0`)	`34` ns/iter (`± 2`)	`1`