Skip to content

Commit

Permalink
CI: Replace wasm_bindgen_check.sh with actually building the web-view…
Browse files Browse the repository at this point in the history
…er (#1604)
  • Loading branch information
emilk authored Mar 17, 2023
1 parent 364f86d commit 217e783
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 47 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,11 @@ jobs:
command: check
args: --locked --target wasm32-unknown-unknown --target-dir target_wasm -p re_renderer --examples

- run: ./scripts/wasm_bindgen_check.sh --skip-setup
- name: Build web-viewer (debug)
uses: actions-rs/cargo@v1
with:
command: run
args: --locked -p re_build_web_viewer -- --debug

# ---------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion scripts/check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ cargo doc --document-private-items --no-deps --all-features
(cd crates/rerun && cargo check --all-features)
(cd examples/rust/objectron && cargo check --all-features)

./scripts/wasm_bindgen_check.sh
cargo run -p re_build_web_viewer -- --debug

./scripts/lint.py

Expand Down
45 changes: 0 additions & 45 deletions scripts/wasm_bindgen_check.sh

This file was deleted.

1 comment on commit 217e783

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 217e783 Previous: 364f86d Ratio
datastore/insert/batch/rects/insert 571442 ns/iter (± 2301) 565626 ns/iter (± 2791) 1.01
datastore/latest_at/batch/rects/query 1897 ns/iter (± 4) 1815 ns/iter (± 5) 1.05
datastore/latest_at/missing_components/primary 285 ns/iter (± 0) 285 ns/iter (± 0) 1
datastore/latest_at/missing_components/secondaries 439 ns/iter (± 0) 438 ns/iter (± 2) 1.00
datastore/range/batch/rects/query 152576 ns/iter (± 344) 152385 ns/iter (± 222) 1.00
mono_points_arrow/generate_message_bundles 47323466 ns/iter (± 717830) 53571375 ns/iter (± 1058657) 0.88
mono_points_arrow/generate_messages 126745758 ns/iter (± 1029971) 141821941 ns/iter (± 1654501) 0.89
mono_points_arrow/encode_log_msg 157765071 ns/iter (± 1340455) 168643961 ns/iter (± 2034860) 0.94
mono_points_arrow/encode_total 331379061 ns/iter (± 1235405) 373382705 ns/iter (± 4015002) 0.89
mono_points_arrow/decode_log_msg 180097694 ns/iter (± 789305) 191288531 ns/iter (± 7707687) 0.94
mono_points_arrow/decode_message_bundles 64690497 ns/iter (± 863620) 76612590 ns/iter (± 1439086) 0.84
mono_points_arrow/decode_total 243367611 ns/iter (± 1314650) 265899147 ns/iter (± 2557182) 0.92
batch_points_arrow/generate_message_bundles 323148 ns/iter (± 606) 326287 ns/iter (± 3260) 0.99
batch_points_arrow/generate_messages 6372 ns/iter (± 12) 6502 ns/iter (± 26) 0.98
batch_points_arrow/encode_log_msg 354200 ns/iter (± 1232) 362765 ns/iter (± 2535) 0.98
batch_points_arrow/encode_total 714454 ns/iter (± 1876) 712671 ns/iter (± 6012) 1.00
batch_points_arrow/decode_log_msg 350486 ns/iter (± 2502) 341372 ns/iter (± 2111) 1.03
batch_points_arrow/decode_message_bundles 2082 ns/iter (± 9) 2090 ns/iter (± 20) 1.00
batch_points_arrow/decode_total 357303 ns/iter (± 989) 367811 ns/iter (± 21060) 0.97
arrow_mono_points/insert 6091936932 ns/iter (± 18853298) 9256181423 ns/iter (± 120643625) 0.66
arrow_mono_points/query 1804911 ns/iter (± 9463) 1847569 ns/iter (± 39588) 0.98
arrow_batch_points/insert 2696428 ns/iter (± 10857) 2862042 ns/iter (± 314987) 0.94
arrow_batch_points/query 16966 ns/iter (± 63) 16966 ns/iter (± 70) 1
arrow_batch_vecs/insert 42871 ns/iter (± 99) 42618 ns/iter (± 150) 1.01
arrow_batch_vecs/query 506667 ns/iter (± 857) 506559 ns/iter (± 1221) 1.00
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.