New time panel density graph (#1557)

* Refactor: move the data density graph to its own file

* Cleanup: use TimeRange

* Refactor: simplify further

* Replace ball scatterer with density graph

* Tweak

* bug fix

* Small refactor

* Create time_range_from_x_range helper

* Allow-list clippy::manual_range_contains

* objectron-rs fix: only log the base objects once

* Normalize the density graphs

* Smooth normalization, and selection color

* Highlight on hover

* Better hover effect

* Better naming: `Item` is called `item`

* Add a consistent line behind the density graph

* Remove dead code

* Integrate re_int_histogram

* Remove static_assert that trips up rust-analyzer

* Cleanup

* Use saturating functions when casting TimeReal -> TimeInt

* Add some TODO:s

* Fix wrong x-range

* Fix typo

* Fix potential integer overflow

* Fix a TODO

* tweaks

* Tweak colors

* Add some tests

* re_int_histogram: make `range` return tight ranges

* Faster data density graph

* Switch to the faster re_int_histogram

* Smoother density graph using box filter

* Code cleanup

* Make TimeAxis run in logarithmic time

* Fix typos

* Tweak the normalization speed

* Self-review cleanup

* Add feathering anti-aliasing to the density graph painter

* use `mod` instead of comments

* Remove dead static_assertions

* typo

Co-authored-by: Jeremy Leibs <[email protected]>

* nits

* fix docstring link

---------

Co-authored-by: Jeremy Leibs <[email protected]>

Cargo.toml

@@ -31,6 +31,7 @@ re_build_web_viewer = { path = "crates/re_build_web_viewer", version = "0.3.1" }
 re_data_store = { path = "crates/re_data_store", version = "0.3.1" }
 re_error = { path = "crates/re_error", version = "0.3.1" }
 re_format = { path = "crates/re_format", version = "0.3.1" }
+re_int_histogram = { path = "crates/re_int_histogram", version = "0.3.1" }
 re_log = { path = "crates/re_log", version = "0.3.1" }
 re_log_types = { path = "crates/re_log_types", version = "0.3.1" }
 re_memory = { path = "crates/re_memory", version = "0.3.1" }

Cranky.toml

@@ -130,7 +130,9 @@ warn = [
 ]
 
 allow = [
-  # TODO(emilk): enable more lints
+  "clippy::manual_range_contains", # this one is just worse imho
+
+  # TODO(emilk): enable more of these lints:
   "clippy::cloned_instead_of_copied",
   "clippy::missing_errors_doc",
   "trivial_casts",

crates/re_data_store/Cargo.toml

@@ -25,6 +25,7 @@ serde = ["dep:serde", "re_log_types/serde"]
 
 [dependencies]
 re_arrow_store.workspace = true
+re_int_histogram.workspace = true
 re_log_types.workspace = true
 re_log.workspace = true
 re_smart_channel.workspace = true

crates/re_data_store/src/entity_tree.rs

@@ -8,30 +8,31 @@ use re_log_types::{
 
 // ----------------------------------------------------------------------------
 
+/// Number of messages per time
+pub type TimeHistogram = re_int_histogram::Int64Histogram;
+
 /// Number of messages per time per timeline
 #[derive(Default)]
-pub struct TimeHistogramPerTimeline(BTreeMap<Timeline, BTreeMap<TimeInt, usize>>);
+pub struct TimeHistogramPerTimeline(BTreeMap<Timeline, TimeHistogram>);
 
 impl TimeHistogramPerTimeline {
     pub fn timelines(&self) -> impl ExactSizeIterator<Item = &Timeline> {
         self.0.keys()
     }
 
-    pub fn get(&self, timeline: &Timeline) -> Option<&BTreeMap<TimeInt, usize>> {
+    pub fn get(&self, timeline: &Timeline) -> Option<&TimeHistogram> {
         self.0.get(timeline)
     }
 
     pub fn has_timeline(&self, timeline: &Timeline) -> bool {
         self.0.contains_key(timeline)
     }
 
-    pub fn iter(&self) -> impl ExactSizeIterator<Item = (&Timeline, &BTreeMap<TimeInt, usize>)> {
+    pub fn iter(&self) -> impl ExactSizeIterator<Item = (&Timeline, &TimeHistogram)> {
         self.0.iter()
     }
 
-    pub fn iter_mut(
-        &mut self,
-    ) -> impl ExactSizeIterator<Item = (&Timeline, &mut BTreeMap<TimeInt, usize>)> {
+    pub fn iter_mut(&mut self) -> impl ExactSizeIterator<Item = (&Timeline, &mut TimeHistogram)> {
         self.0.iter_mut()
     }
 }
@@ -239,13 +240,11 @@ impl EntityTree {
             self.num_timeless_messages += 1;
         } else {
             for (timeline, time_value) in time_point.iter() {
-                *self
-                    .prefix_times
+                self.prefix_times
                     .0
                     .entry(*timeline)
                     .or_default()
-                    .entry(*time_value)
-                    .or_default() += 1;
+                    .increment(time_value.as_i64(), 1);
             }
         }
 
@@ -293,10 +292,10 @@ impl EntityTree {
             components: fields,
         } = self;
 
-        for (timeline, map) in &mut prefix_times.0 {
+        for (timeline, histogram) in &mut prefix_times.0 {
             crate::profile_scope!("prefix_times");
             if let Some(cutoff_time) = cutoff_times.get(timeline) {
-                map.retain(|time_int, _count| cutoff_time.is_timeless() || cutoff_time <= time_int);
+                histogram.remove(..cutoff_time.as_i64());
             }
         }
         {
@@ -349,13 +348,11 @@ impl ComponentStats {
             self.num_timeless_messages += 1;
         } else {
             for (timeline, time_value) in time_point.iter() {
-                *self
-                    .times
+                self.times
                     .0
                     .entry(*timeline)
                     .or_default()
-                    .entry(*time_value)
-                    .or_default() += 1;
+                    .increment(time_value.as_i64(), 1);
             }
         }
     }
@@ -366,9 +363,9 @@ impl ComponentStats {
             num_timeless_messages: _,
         } = self;
 
-        for (timeline, time_counts) in &mut times.0 {
+        for (timeline, histogram) in &mut times.0 {
             if let Some(cutoff_time) = cutoff_times.get(timeline) {
-                time_counts.retain(|time_int, _count| cutoff_time <= time_int);
+                histogram.remove(..cutoff_time.as_i64());
             }
         }
     }