Skip to content

Commit

Permalink
All C++ datatypes & components now implement a new Loggable trait (#4305
Browse files Browse the repository at this point in the history
)

### What

This moves all serialization related methods off of the respective
structs themselves, leading to better auto complete.
`AsComponents`.
The default implementations of `AsComponents` now all require input
types to implement this new trait - before they just required the
to_data_cell method to be there (that's still the case, but now with an
indirection ;))

This makes our interface cleaner and paves the way to a good fix for:
* #3260

(there's a few details still missing for this to allow custom types
without dragging in arrow headers, but one thing at a time!)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4305) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4305)
- [Docs
preview](https://rerun.io/preview/c494b2e513d28ed53b456caaf890901bd2d7c6b4/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/c494b2e513d28ed53b456caaf890901bd2d7c6b4/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
  • Loading branch information
Wumpf authored Nov 23, 2023
1 parent c4126cf commit 13ac376
Show file tree
Hide file tree
Showing 263 changed files with 5,405 additions and 2,179 deletions.
341 changes: 166 additions & 175 deletions crates/re_types_builder/src/codegen/cpp/mod.rs

Large diffs are not rendered by default.

11 changes: 5 additions & 6 deletions rerun_cpp/src/rerun/archetypes/annotation_context.cpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions rerun_cpp/src/rerun/archetypes/annotation_context.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 9 additions & 11 deletions rerun_cpp/src/rerun/archetypes/arrows3d.cpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions rerun_cpp/src/rerun/archetypes/arrows3d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions rerun_cpp/src/rerun/archetypes/asset3d.cpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions rerun_cpp/src/rerun/archetypes/asset3d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions rerun_cpp/src/rerun/archetypes/bar_chart.cpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions rerun_cpp/src/rerun/archetypes/bar_chart.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions rerun_cpp/src/rerun/archetypes/boxes2d.cpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions rerun_cpp/src/rerun/archetypes/boxes2d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 13ac376

Please sign in to comment.