Skip to content

Commit

Permalink
Remove unnecessary dependencies (#1711)
Browse files Browse the repository at this point in the history 
* remove unnecessary dependencies from re_viewer

* remove more unused dependencies

* remove some more external unused dependencies

* update cargo lock

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
  • Loading branch information
@vsuryamurthy @emilk
vsuryamurthy and emilk authored Mar 30, 2023
1 parent 82f5d69 commit 118630c
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 34 deletions.
17 changes: 0 additions & 17 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/re_build_build_info/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@ all-features = true

[dependencies]
anyhow.workspace = true
glob = "0.3"
time = { workspace = true, features = ["formatting"] }
2 changes: 0 additions & 2 deletions crates/re_data_store/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,9 @@ re_smart_channel.workspace = true
re_string_interner.workspace = true

ahash.workspace = true
anyhow = "1.0"
document-features = "0.2"
itertools = { workspace = true }
nohash-hasher = "0.2"
once_cell = "1.15.0"
serde = { version = "1", features = ["derive", "rc"], optional = true }
thiserror = "1.0"

Expand Down
3 changes: 0 additions & 3 deletions crates/re_query/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,12 @@ re_log_types.workspace = true
re_log.workspace = true

# External dependencies:
anyhow.workspace = true
arrow2 = { workspace = true, features = [
"compute_concatenate",
"compute_aggregate",
] }
document-features = "0.2"
indent = "0.1"
itertools = { workspace = true }
nohash-hasher = "0.2"
thiserror.workspace = true

# Optional dependencies:
Expand Down
1 change: 0 additions & 1 deletion crates/re_renderer/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ glam = { workspace = true, features = ["bytemuck"] }
half = { workspace = true, features = ["bytemuck"] }
itertools = { workspace = true }
macaw.workspace = true
memoffset = "0.8"
ordered-float = "3.2"
parking_lot.workspace = true
slotmap = "1.0.6"
Expand Down
3 changes: 0 additions & 3 deletions crates/re_sdk/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@ re_sdk_comms = { workspace = true, features = ["client"] }
re_smart_channel.workspace = true

anyhow.workspace = true
arrow2.workspace = true
crossbeam = "0.8"
document-features = "0.2"
lazy_static.workspace = true
nohash-hasher = "0.2"
parking_lot.workspace = true
thiserror.workspace = true
Expand Down
2 changes: 0 additions & 2 deletions crates/re_tensor_ops/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,5 @@ all-features = true
re_log_types.workspace = true

ahash.workspace = true
bytemuck = { version = "1.12", features = ["extern_crate_alloc"] }
ndarray.workspace = true
serde = { version = "1", features = ["derive"] }
thiserror = "1.0"
2 changes: 0 additions & 2 deletions crates/re_viewer/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,9 @@ instant = { version = "0.1", features = ["wasm-bindgen"] }
itertools = { workspace = true }
lazy_static.workspace = true
macaw = { workspace = true, features = ["with_serde"] }
mint = "0.5"
ndarray = "0.15"
nohash-hasher = "0.2"
poll-promise = "0.2"
rand = { version = "0.8", features = ["small_rng"] }
rfd = { version = "0.11.3", default_features = false, features = [
"xdg-portal",
] }
Expand Down
3 changes: 0 additions & 3 deletions crates/rerun/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,10 @@ re_smart_channel.workspace = true
re_ws_comms = { workspace = true, features = ["client"] }

anyhow.workspace = true
crossbeam = "0.8"
document-features = "0.2"
egui = { workspace = true, default-features = false }
itertools = { workspace = true }
parking_lot.workspace = true
puffin.workspace = true

# Optional dependencies:
re_analytics = { workspace = true, optional = true }
Expand All @@ -96,7 +94,6 @@ webbrowser = { version = "0.8", optional = true }
backtrace = "0.3"
clap = { workspace = true, features = ["derive"] }
mimalloc.workspace = true
puffin_http = "0.11"
ctrlc.workspace = true
tokio = { workspace = true, features = ["macros", "rt-multi-thread"] }

Expand Down

1 comment on commit 118630c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 118630c Previous: 82f5d69 Ratio
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 12379764 ns/iter (± 657716) 10706570 ns/iter (± 389113) 1.16
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=0 14032856 ns/iter (± 630549) 12452965 ns/iter (± 359625) 1.13
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2 13325329 ns/iter (± 790890) 11718709 ns/iter (± 366919) 1.14
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=32 11151192 ns/iter (± 533348) 10344431 ns/iter (± 349602) 1.08
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2048 10993438 ns/iter (± 433677) 10205868 ns/iter (± 334515) 1.08
datastore/num_rows=1000/num_instances=1000/packed=true/insert/default 10704961 ns/iter (± 520279) 9931804 ns/iter (± 351812) 1.08
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=0 13012367 ns/iter (± 724960) 11597255 ns/iter (± 597620) 1.12
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2 12828264 ns/iter (± 783052) 11200708 ns/iter (± 457977) 1.15
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=32 11675537 ns/iter (± 843174) 10043978 ns/iter (± 350760) 1.16
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2048 10819004 ns/iter (± 619410) 9999497 ns/iter (± 315662) 1.08
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 1841 ns/iter (± 17) 1806 ns/iter (± 37) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=0 1863 ns/iter (± 3) 1837 ns/iter (± 26) 1.01
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2 1861 ns/iter (± 2) 1829 ns/iter (± 25) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=32 1851 ns/iter (± 1) 1804 ns/iter (± 25) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2048 1855 ns/iter (± 4) 1797 ns/iter (± 26) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/default 1842 ns/iter (± 20) 1827 ns/iter (± 29) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=0 1871 ns/iter (± 7) 1838 ns/iter (± 24) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2 1867 ns/iter (± 4) 1815 ns/iter (± 24) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=32 1841 ns/iter (± 1) 1807 ns/iter (± 22) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2048 1849 ns/iter (± 0) 1814 ns/iter (± 27) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 279 ns/iter (± 0) 273 ns/iter (± 4) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 434 ns/iter (± 0) 420 ns/iter (± 5) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=0 280 ns/iter (± 0) 272 ns/iter (± 3) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=0 442 ns/iter (± 0) 429 ns/iter (± 6) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2 280 ns/iter (± 0) 274 ns/iter (± 3) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2 442 ns/iter (± 0) 430 ns/iter (± 6) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=32 280 ns/iter (± 0) 272 ns/iter (± 4) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=32 445 ns/iter (± 0) 426 ns/iter (± 6) 1.04
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2048 280 ns/iter (± 0) 273 ns/iter (± 4) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2048 436 ns/iter (± 0) 428 ns/iter (± 6) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/default 282 ns/iter (± 0) 272 ns/iter (± 4) 1.04
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/default 433 ns/iter (± 0) 425 ns/iter (± 6) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=0 283 ns/iter (± 0) 275 ns/iter (± 4) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=0 442 ns/iter (± 0) 430 ns/iter (± 6) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2 283 ns/iter (± 0) 271 ns/iter (± 3) 1.04
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2 442 ns/iter (± 0) 428 ns/iter (± 5) 1.03
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=32 283 ns/iter (± 0) 272 ns/iter (± 3) 1.04
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=32 440 ns/iter (± 0) 422 ns/iter (± 5) 1.04
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2048 283 ns/iter (± 0) 273 ns/iter (± 4) 1.04
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2048 435 ns/iter (± 0) 420 ns/iter (± 6) 1.04
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 13580447 ns/iter (± 1338003) 10731768 ns/iter (± 391536) 1.27
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=0 2229375 ns/iter (± 18821) 2426758 ns/iter (± 24070) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2 2135611 ns/iter (± 7671) 2356495 ns/iter (± 23638) 0.91
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=32 1887581 ns/iter (± 7398) 2056590 ns/iter (± 21943) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2048 1895081 ns/iter (± 16027) 1939902 ns/iter (± 24654) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/range/default 12127148 ns/iter (± 1145753) 10241736 ns/iter (± 538329) 1.18
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=0 2172117 ns/iter (± 16952) 2375451 ns/iter (± 29926) 0.91
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2 2224646 ns/iter (± 24429) 2389685 ns/iter (± 22242) 0.93
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=32 1882330 ns/iter (± 18286) 2044606 ns/iter (± 23931) 0.92
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2048 1862335 ns/iter (± 100433) 1982228 ns/iter (± 22101) 0.94
mono_points_arrow/generate_message_bundles 47556952 ns/iter (± 1744151) 40599288 ns/iter (± 697218) 1.17
mono_points_arrow/generate_messages 184952998 ns/iter (± 2178062) 165205809 ns/iter (± 1451326) 1.12
mono_points_arrow/encode_log_msg 228848482 ns/iter (± 2771203) 205478067 ns/iter (± 1474392) 1.11
mono_points_arrow/encode_total 452197250 ns/iter (± 2349357) 412623098 ns/iter (± 2059405) 1.10
mono_points_arrow/decode_log_msg 268471765 ns/iter (± 1109366) 253241563 ns/iter (± 1595261) 1.06
mono_points_arrow/decode_message_bundles 101372522 ns/iter (± 955933) 84861512 ns/iter (± 1103824) 1.19
mono_points_arrow/decode_total 364789697 ns/iter (± 2207278) 336380010 ns/iter (± 2357202) 1.08
mono_points_arrow_batched/generate_message_bundles 34499540 ns/iter (± 1754024) 30957516 ns/iter (± 1271417) 1.11
mono_points_arrow_batched/generate_messages 10191808 ns/iter (± 809149) 9263854 ns/iter (± 397210) 1.10
mono_points_arrow_batched/encode_log_msg 1780969 ns/iter (± 10346) 1931279 ns/iter (± 19131) 0.92
mono_points_arrow_batched/encode_total 48392635 ns/iter (± 2993308) 44449171 ns/iter (± 1420466) 1.09
mono_points_arrow_batched/decode_log_msg 982645 ns/iter (± 5663) 1065718 ns/iter (± 9497) 0.92
mono_points_arrow_batched/decode_message_bundles 17529663 ns/iter (± 1978381) 16651452 ns/iter (± 712473) 1.05
mono_points_arrow_batched/decode_total 20790421 ns/iter (± 951830) 18118866 ns/iter (± 686053) 1.15
batch_points_arrow/generate_message_bundles 288739 ns/iter (± 1095) 280045 ns/iter (± 4128) 1.03
batch_points_arrow/generate_messages 7653 ns/iter (± 19) 7381 ns/iter (± 99) 1.04
batch_points_arrow/encode_log_msg 390895 ns/iter (± 1963) 425198 ns/iter (± 3168) 0.92
batch_points_arrow/encode_total 694653 ns/iter (± 2013) 717571 ns/iter (± 8166) 0.97
batch_points_arrow/decode_log_msg 337199 ns/iter (± 1221) 361435 ns/iter (± 3655) 0.93
batch_points_arrow/decode_message_bundles 2883 ns/iter (± 7) 2790 ns/iter (± 38) 1.03
batch_points_arrow/decode_total 350415 ns/iter (± 1001) 368416 ns/iter (± 3757) 0.95
arrow_mono_points/insert 7060741725 ns/iter (± 12411274) 6182615719 ns/iter (± 22343798) 1.14
arrow_mono_points/query 1798259 ns/iter (± 15633) 1851832 ns/iter (± 20835) 0.97
arrow_batch_points/insert 2994901 ns/iter (± 7327) 3113566 ns/iter (± 30277) 0.96
arrow_batch_points/query 16931 ns/iter (± 21) 16716 ns/iter (± 252) 1.01
arrow_batch_vecs/insert 43045 ns/iter (± 179) 45410 ns/iter (± 646) 0.95
arrow_batch_vecs/query 535786 ns/iter (± 1691) 506513 ns/iter (± 6390) 1.06
tuid/Tuid::random 42 ns/iter (± 0) 33 ns/iter (± 0) 1.27

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.