Add nitpicky lint (#2332)

### What
https://github.com/rerun-io/rerun/blob/main/CODE_STYLE.md#misc

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2332

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/42af6f4/docs
Examples preview: https://rerun.io/preview/42af6f4/examples
<!-- pr-link-docs:end -->

---------

Co-authored-by: Andreas Reich <[email protected]>

crates/re_viewer_context/src/space_view/space_view_class_registry.rs

@@ -4,8 +4,8 @@ use crate::{DynSpaceViewClass, SpaceViewClassName};
 
 #[derive(Debug, thiserror::Error)]
 pub enum SpaceViewClassRegistryError {
-    #[error("Space view with typename \"{0}\" was already registered.")]
-    DuplicateTypeName(SpaceViewClassName),
+    #[error("Space view with class name {0:?} was already registered.")]
+    DuplicateClassName(SpaceViewClassName),
 }
 
 /// Registry of all known space view types.
@@ -28,7 +28,7 @@ impl SpaceViewClassRegistry {
             .insert(type_name, Box::new(space_view_type))
             .is_some()
         {
-            return Err(SpaceViewClassRegistryError::DuplicateTypeName(type_name));
+            return Err(SpaceViewClassRegistryError::DuplicateClassName(type_name));
         }
 
         Ok(())

scripts/lint.py

@@ -21,6 +21,7 @@
 wasm_caps = re.compile(r"\bWASM\b")
 nb_prefix = re.compile(r"nb_")
 else_return = re.compile(r"else\s*{\s*return;?\s*};")
+explicit_quotes = re.compile(r'[^(]\\"\{\w*\}\\"')  # looks for: \"{foo}\"
 
 
 def lint_line(line: str) -> Optional[str]:
@@ -77,6 +78,9 @@ def lint_line(line: str) -> Optional[str]:
     if nb_prefix.search(line):
         return "Don't use nb_things - use num_things or thing_count instead"
 
+    if explicit_quotes.search(line):
+        return "Prefer using {:?} - it will also escape newlines etc"
+
     return None
 
 
@@ -103,6 +107,7 @@ def test_lint_line() -> None:
         "num_instances",
         "instances_count",
         "let Some(foo) = bar else { return; };",
+        "{foo:?}",
     ]
 
     should_error = [
@@ -124,6 +129,9 @@ def test_lint_line() -> None:
         "let Some(foo) = bar else {return;};",
         "let Some(foo) = bar else {return};",
         "let Some(foo) = bar else { return };",
+        r'println!("Problem: \"{}\"", string)',
+        r'println!("Problem: \"{0}\"")',
+        r'println!("Problem: \"{string}\"")',
     ]
 
     for line in should_pass: