-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MediaType::guess_from_path
: enforce .obj
extension to be Wavefron…
…t Obj (#3772) [`mime_guess` maps `.obj` to `tgif` files...](https://github.com/abonander/mime_guess/blob/fa5759c1bed87abea7af341ab2e50f51b0599326/src/mime_types.rs#L787) but let's be real: nobody expects a `tgif` file. This also made me realize that `mime_guess` is unmaintained and missing some important stuff (e.g. JPEG XL) and we should switch to `mime_guess2`... but for that we must first switch `egui_commonmark` to `mime_guess2` 😭 Also, we don't load associated mtl files when loading objs, which makes their use pretty limited... ``` $ rerun /tmp/bm/bmw.obj ``` ![image](https://github.com/rerun-io/rerun/assets/2910679/127b7be4-5b51-4450-b9cf-b246262e6c01) - Fixes #3703
- Loading branch information
Showing
9 changed files
with
23 additions
and
7 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters