-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce support for querying Archetypes (#2743)
### What The main change here is to introduce a new `ArchetypeView` that uses the archetype interfaces as an alternative to the historical `EntityView`. Because EntityViews and legacy type definitions leak through numerous APIs, this involved forking a number of APIs: - `process_archetype_views` - `query_archetype_with_history` - `query_archetype` - `range_archetype` - `process_color_arch` - `process_radii_arch` - `process_annotations_and_keypoints_arch` As we migrate more of our queries to the new APIs, the legacy versions of these helpers can be incrementally deleted and potentially renamed as appropriate. ### Future work This does not yet replicated the `query_tests` and `range_tests` for Archetype APIs. Part of the reason for this is that we make heavy use of `DataCell` construction in those tests, but DataCells are still heavily dependent on the legacy Component APIs. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2743) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2743) - [Docs preview](https://rerun.io/preview/pr%3Ajleibs%2Fhope_queries/docs) - [Examples preview](https://rerun.io/preview/pr%3Ajleibs%2Fhope_queries/examples)
- Loading branch information
Showing
25 changed files
with
1,469 additions
and
80 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
00eeacb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
1.25
.batch_points_arrow/encode_log_msg
90332
ns/iter (± 289
)50449
ns/iter (± 123
)1.79
This comment was automatically generated by workflow using github-action-benchmark.