Skip to content
This repository was archived by the owner on Apr 14, 2025. It is now read-only.

Fix unsound problem in Row::row_unchecked #5

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix unsound problem in Row::row_unchecked #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7f8009
Fix the unsond problem in Rows
safe4u Jul 9, 2024
b569f83
Update affected use of row_unchecked
safe4u Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/compute/sort/row/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,10 @@ pub struct Rows {

impl Rows {
/// Get a reference to a certain row.
///
/// # Panics
///
/// Panics if `row` is out of bounds
pub fn row(&self, row: usize) -> Row<'_> {
let end = self.offsets[row + 1];
let start = self.offsets[row];
Expand All @@ -269,7 +273,12 @@ impl Rows {
}

/// Get a reference to a certain row but not check the bounds.
pub fn row_unchecked(&self, row: usize) -> Row<'_> {
///
/// # Safety
///
/// The caller must ensure that `row` is within bounds
pub unsafe fn row_unchecked(&self, row: usize) -> Row<'_> {
debug_assert!(row < self.len(), "out-of-bounds access");
let data = unsafe {
let end = *self.offsets.get_unchecked(row + 1);
let start = *self.offsets.get_unchecked(row);
Expand Down Expand Up @@ -319,7 +328,7 @@ impl<'a> Iterator for RowsIter<'a> {
#[inline]
fn next(&mut self) -> Option<Self::Item> {
if self.start < self.end {
let row = self.rows.row_unchecked(self.start);
let row = unsafe { self.rows.row_unchecked(self.start) };
self.start += 1;
Some(row)
} else {
Expand Down