Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tokio an optional dependency, and add fn ws_receive #24

Merged
merged 8 commits into from
Oct 7, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 6, 2023

This strips a lot of dependencies from the native build by default, to make tokio opt-in.

It also adds a new ws_receive function that is simpler and faster on native, for when you only need to receive message, and never send any.

TODO

  • Use document-features crate
  • Test with tokio
  • Test without tokio
  • Test web
  • Test with Rerun

@emilk emilk merged commit bf2ccd0 into main Oct 7, 2023
6 checks passed
@emilk emilk mentioned this pull request Oct 7, 2023
4 tasks
emilk added a commit to rerun-io/rerun that referenced this pull request Oct 10, 2023
This unblocks us from updating `tunstenite` to fix RUSTSEC-2023-0065

This also removes a few dependencies, thanks to:
* rerun-io/ewebsock#24

I've tested that it still works.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3729) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3729)
- [Docs
preview](https://rerun.io/preview/1378634af462a895fea11b44a2dd08e766ed7176/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1378634af462a895fea11b44a2dd08e766ed7176/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant