Skip to content

Commit

Permalink
Fix log_static and mcap build (#11)
Browse files Browse the repository at this point in the history
* Use log_static instead of log_timeless

* Fix mcap build

* Remove outdated comment regarding pypi deps in pixi
  • Loading branch information
roym899 authored Jul 3, 2024
1 parent 162bbd7 commit bc8cb32
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions pixi.toml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ cwd = "humble_ws"
[tasks.rosbag2_storage_mcap]
cmd = """
(test -d src/rosbag2_storage_mcap || git clone https://github.com/ros-tooling/rosbag2_storage_mcap.git src/rosbag2_storage_mcap)
&& colcon build --packages-select rosbag2_storage_mcap --cmake-args -DCMAKE_BUILD_TYPE=Release
&& colcon build --packages-select mcap_vendor rosbag2_storage_mcap_testdata rosbag2_storage_mcap --cmake-args -DCMAKE_BUILD_TYPE=Release
"""
depends_on = ["ws"]
cwd = "humble_ws"
Expand Down Expand Up @@ -104,11 +104,6 @@ depends_on = ["build", "go2_example_data", "go2_ros2_sdk", "rosbag2_storage_mcap
cwd = "humble_ws"

# Install Rerun and URDF loader manually via pip3, this should be replaced with direct pypi dependencies in the future.
# Wait for direct branch and find-links support in pixi. Otherwise updating to a prerelease becomes a hassle.
# See:
# https://pixi.sh/latest/reference/configuration/#pypi-dependencies-beta-feature
# https://github.com/prefix-dev/pixi/issues/1163

[tasks.rerun_viewer]
cmd = "pip install rerun-sdk==0.16"

Expand Down
2 changes: 1 addition & 1 deletion rerun_bridge/src/rerun_bridge/visualizer_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ void RerunLoggerNode::_read_yaml_config(std::string yaml_path) {
extra_pinhole["image_from_camera"][5].as<float>(),
extra_pinhole["image_from_camera"][8].as<float>(),
};
_rec.log_timeless(
_rec.log_static(
extra_pinhole["entity_path"].as<std::string>(),
rerun::Pinhole(image_from_camera)
.with_resolution(
Expand Down

0 comments on commit bc8cb32

Please sign in to comment.