setup: fix old pipenv environment variables #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently RERO-ils changed pipenv to poetry. The setup used a specific option `-w` that reduced displayed messages. It uses FLASK_SKIP_DOTENV for that. But this variable is problematic with the new poetry system as it skip `.env` files (used for development, production, etc.). This commit removes this old variable and fix a bootstrap problem too. * Deletes FLASK_SKIP_DOTENV variable * Fixes Travis test while bootstraping Co-Authored-by: Olivier DOSSMANN <[email protected]>
jma
approved these changes
May 15, 2020
rerowep
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently RERO-ils changed pipenv to poetry. The setup used a specific
option
-wthat reduced displayed messages.It uses FLASK_SKIP_DOTENV for that. But this variable is problematic
with the new poetry system as it skip
.envfiles (used fordevelopment, production, etc.).
This commit removes this old variable and fix a bootstrap problem too.
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
While launching
poetry run setup -P -w, the setup didn't find the.envfile in which I add specific customization (for example for RERO_ILS_CSS or specific REDIS ports).This comes from
FLASK_SKIP_DOTENVused previously with pipenv. This is not needed anymore!How to test?
.envwithINVENIO_INSTANCE_PATH=../var/ils../var/ils/invenio.cfgchange a specific variable, for exampleCACHE_REDIS_URL="redis://0.0.0.0:8888/0"- 8888:6379docker-compose down && docker-compose up -d && ./docker/wait-for-services.shpoetry run setup -P -wIt should start.
To be sure, you can test the same thing on
devbranch.Code review check list