Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: use poetry #986

Merged
merged 1 commit into from
May 12, 2020
Merged

dependencies: use poetry #986

merged 1 commit into from
May 12, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented May 11, 2020 •
edited
Loading

Pipenv was used before, but often when a new version of dependency is
published, we need to adapt the Pipenv file to fix travis errors. This
is mainly due to the pipenv dependencies resolution
algorithm.

  • Adapts docker files.
  • Uses poetry for the travis tests.
  • Uses python-dotenv to load .env and .flaskenv files and adapts the
    tests accordingly.
  • Updates the documentation.
  • Fixes the item view and the tests detected thanks to an upgrade of
    werkzeug.
  • Removes bad appnope hacks by mark this macosx specific package
    optional.
  • Removes the setuptools manifest checks as it is not used until now and
    causes problems with poetry: probably it is useless.
  • Adapts all local scripts.
  • Removes useless constraints.
  • Adds celery configuration to load .env and .flaskenv files.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • To fix dependencies recurrents problems

How to test?

Available commands

  • poetry run bootstrap
  • poetry run console
  • poetry run run-tests
  • poetry run tests
  • poetry run server
  • poetry run setup
  • poetry run update
  • poetry run python ./setup.py extract_messages
  • poetry run python ./setup.py update_catalog
  • poetry run python ./setup.py compile_catalog

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-poetry branch 10 times, most recently from d898555 to f626405 Compare May 12, 2020 06:09
@jma jma changed the title install: use poetry instead of pipenv dependencies: use poetry May 12, 2020
@jma jma marked this pull request as ready for review May 12, 2020 06:15
@jma jma requested review from blankoworld and rerowep May 12, 2020 06:16
@jma jma marked this pull request as draft May 12, 2020 06:35
rerowep
rerowep reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run poetry only in one terminal.

@jma jma force-pushed the maj-poetry branch 2 times, most recently from 06706fb to 8d70ab5 Compare May 12, 2020 06:52
@jma jma marked this pull request as ready for review May 12, 2020 06:52
@jma jma force-pushed the maj-poetry branch 3 times, most recently from d8ea293 to 0b37449 Compare May 12, 2020 07:19
blankoworld
blankoworld reviewed May 12, 2020
View reviewed changes
lauren-d
lauren-d approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@lauren-d lauren-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap, setup and server works as expected.
run-tests successfully passed.

@blankoworld
Copy link
Contributor

Server gives something like that: [2020-05-12 11:46:39,102] ERROR in app: Failed to initialize entry point: invenio_records = invenio_records:InvenioRecords Error: Unable to load celery application. The module flask_bootstrap was not found.

@jma jma force-pushed the maj-poetry branch 2 times, most recently from c55082e to 0f81cef Compare May 12, 2020 12:51
@jma jma force-pushed the maj-poetry branch 3 times, most recently from a601a54 to 688341f Compare May 12, 2020 13:40
@BadrAly
Copy link

BadrAly commented May 12, 2020

The code coverage seems to go red. I do not know why.

@jma jma force-pushed the maj-poetry branch 2 times, most recently from 7c18cb1 to f84a1fa Compare May 12, 2020 14:06
@jma
dependencies: use poetry
66798bd 
Pipenv was used before, but often when a new version of dependency is
published, we need to adapt the Pipenv file to fix travis errors. This
is mainly due to the pipenv dependencies resolution
algorithm.

* Adapts docker files.
* Uses poetry for the travis tests.
* Uses python-dotenv to load .env and .flaskenv files and adapts the
tests accordingly.
* Updates the documentation.
* Fixes the item view and the tests detected thanks to an upgrade of
werkzeug.
* Removes bad appnope hacks by mark this macosx specific package
optional.
* Removes the setuptools manifest checks as it is not used until now and
causes problems with poetry: probably it is useless.
* Adapts all local scripts.
* Removes useless constraints.
* Adds celery configuration to load .env and .flaskenv files.
* Adds invenio-logging sentry extensions.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma merged commit 047f231 into rero:dev May 12, 2020
@jma jma deleted the maj-poetry branch January 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankoworld blankoworld blankoworld approved these changes

@BadrAly BadrAly BadrAly approved these changes

@rerowep rerowep rerowep approved these changes

@lauren-d lauren-d lauren-d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jma @blankoworld @BadrAly @rerowep @lauren-d