tests: fix travis trouble with pytest-invenio #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last days a [new pytest-invenio 1.2.2 version](inveniosoftware/pytest-invenio@9a5d15b) was released. It downgrades our pytest-flask from 1.0.0 to 0.15.1 and our Flask from 1.1.2 to 1.04. These changes break our tests. Mainly with Flask and werkzeug problems. Cf. https://travis-ci.org/github/blankoworld/rero-ils/jobs/684571964#L1905 For now, this commit limits tests problem by keeping our pytest-invenio version, pytest-flask and Flask. * Fix pytest-invenio to 1.2.1 to avoid problems in our tests Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
doo-fix-flask-downgrade-problem
branch
from
a96b4f6 to
6ebf102
Compare
BadrAly
approved these changes
May 11, 2020
| @@ -726,7 +726,8 @@ def test_update_loan_pickup_location( | |||
| ) | |||
| assert res.status_code == 200 | |||
| assert data.get('pickup_location_pid') == new_loc_pid | |||
| # Change loan state to 'ITEM_AT_DESK' | |||
| # Change loan state to 'ITEM_AT_DESK'. | |||
| # WARNING: Use loan from test_patron_checkouts_order (item3_lib_martigny) | |||
There was a problem hiding this comment.
Is this a valid comment? because it is using the item3_lib_martigny
# WARNING: Use loan from test_patron_checkouts_order (item3_lib_martigny)
There was a problem hiding this comment.
Yes! This explain that we use an item from a previous test!
There was a problem hiding this comment.
Is it really related to this commit?
jma
requested changes
May 11, 2020
blankoworld
added a commit
to blankoworld/rero-ils
that referenced
this pull request
May 11, 2020
Last days a [new pytest-invenio 1.2.2 version](inveniosoftware/pytest-invenio@9a5d15b) was released. It downgrades our pytest-flask from 1.0.0 to 0.15.1 and our Flask from 1.1.2 to 1.04. These changes break our tests. Mainly with Flask and werkzeug problems. Cf. https://travis-ci.org/github/blankoworld/rero-ils/jobs/684571964#L1905 We created a PR to fix quickly the problem: Cf. rero#981. But we need to improve our Pipfile, especially the [dev] section. This commit upgrade our Pipfile to follow invenio recommandations. Co-Authored-by: Olivier DOSSMANN <[email protected]>
7 tasks
jma
approved these changes
May 11, 2020
| @@ -726,7 +726,8 @@ def test_update_loan_pickup_location( | |||
| ) | |||
| assert res.status_code == 200 | |||
| assert data.get('pickup_location_pid') == new_loc_pid | |||
| # Change loan state to 'ITEM_AT_DESK' | |||
| # Change loan state to 'ITEM_AT_DESK'. | |||
| # WARNING: Use loan from test_patron_checkouts_order (item3_lib_martigny) | |||
There was a problem hiding this comment.
Is it really related to this commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last days a new pytest-invenio 1.2.2 version was released.
It downgrades our pytest-flask from 1.0.0 to 0.15.1 and our Flask from
1.1.2 to 1.04.
These changes break our tests. Mainly with Flask and werkzeug problems.
Cf. https://travis-ci.org/github/blankoworld/rero-ils/jobs/684571964#L1905
For now, this commit limits tests problem by keeping our pytest-invenio
version, pytest-flask and Flask.
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
This should fix the issue about tests like here: https://travis-ci.org/github/rero/rero-ils/jobs/684554447
How to test?
Code review check list