tests: fix units testing for generated item barcodes #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current units testing ensures that the timestamp of the generated barcode equals the sysdate timestamp. This was incorrect because the time of the item creation/barcode generation is different from the sysdate at running the assert command. Now we test only if the barcode starts with f-. Co-Authored-by: Aly Badr<[email protected]>
BadrAly
force-pushed
the
baa-fix-barcode-testing
branch
from
11f4ad5 to
7e06f09
Compare
jma
approved these changes
May 7, 2020
zannkukai
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current units testing ensures that the timestamp of the
generated barcode equals the sysdate timestamp. This was incorrect
because the time of the item creation/barcode generation is different
from the sysdate at running the assert command.
Now we test only if the barcode starts with f-.
Co-Authored-by: Aly Badr[email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list