Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location: unique pickup location for a library #976

Merged
merged 1 commit into from
May 7, 2020

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented May 6, 2020

This commit adds check to limit to only one pickup location for a library.

Co-Authored-by: Renaud Michotte [email protected]

Same than #969 (closed by error)

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai force-pushed the zan-#unique-pickup branch from 8d96519 to ff6c840 Compare May 6, 2020 14:34
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title proposition: location: restrict library pickup location to one.

@zannkukai zannkukai force-pushed the zan-#unique-pickup branch from ff6c840 to 285c0a6 Compare May 7, 2020 07:54
@zannkukai zannkukai requested a review from iGormilhit May 7, 2020 07:58
This commit adds check to limit to only one pickup location for a library.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-#unique-pickup branch from 285c0a6 to 7c2cf20 Compare May 7, 2020 07:59
@zannkukai zannkukai merged commit 2e65b41 into rero:dev May 7, 2020
@zannkukai zannkukai deleted the zan-#unique-pickup branch May 7, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants