-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
item: multiple inheritance for the item class #968
Conversation
e822b42
to
d989051
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run-test => OK
Installed locally and tested CKO/CKI/Renew/Request. => OK
@benerken Thanks a lot for the test.
Please verify the creation of a new item.
when you type the barcode, the console shows an error "Backend returned code 400, body was: [object Object]"The save button is disabled => Impossible to create an item.
I use the Admin UI "included" in rero-ils (via port 5000), so not a specific version on port 4200
I was able to duplicate the problem locally, however if I connect to rero_ils_ui.dev
it works nicely. I am adding rero_ils_ui.dev
as dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'am not sure it is the right way to put classes into the __init__.py
file ?
https://docs.python.org/3/tutorial/modules.html#packages
d989051
to
93f797f
Compare
61be45b
to
c7f5cca
Compare
Since the item class is used now to manage two things: 1. the item record 2. the item circulation transactions Two base classes are created for each section above in api.record:ItemRecord, api.circulation:ItemCirculation The main Item class inherites from these two classes. Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Aly Badr<[email protected]>
c7f5cca
to
58002ef
Compare
Since the item class is used now to manage two things:
Two base classes are created for each section above in
api.record:ItemRecord, api.circulation:ItemCirculation
The main Item class inherites from these two classes.
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Aly Badr[email protected]
Why are you opening this PR?
re-organising the class Item
How to test?
Must have
rero_ils_ui.dev
./run_tests.sh
Code review check list