release: v0.8.0 #966
Merged
release: v0.8.0 #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronguen
approved these changes
May 4, 2020
RELEASE-NOTES.rst
Outdated
Comment on lines
41
to
42
| - Adds the librarian organisation as a parameter in the documents title | ||
| of the search results. |
There was a problem hiding this comment.
I don't really understand in the documents title of the search results.
RELEASE-NOTES.rst
Outdated
Comment on lines
43
to
44
| - Adds an history tab in the patron profile to display the loans | ||
| history of the last 6 months. |
There was a problem hiding this comment.
Suggested change
| - Adds an history tab in the patron profile to display the loans | |
| history of the last 6 months. | |
| - Adds a history tab in the patron profile to display the loan | |
| history of the last 6 months. |
RELEASE-NOTES.rst
Outdated
| - Adds an history tab in the patron profile to display the loans | ||
| history of the last 6 months. | ||
| - Updates the patron type detailed view with new subscription fields. | ||
| - Adds an holding editor to define: |
There was a problem hiding this comment.
Suggested change
| - Adds an holding editor to define: | |
| - Adds a holding editor to define: |
RELEASE-NOTES.rst
Outdated
| - Standard with the add/edit buttons to load the item editor. | ||
| - Electronic with no action available (replaces the ``harvested`` | ||
| property mechanism). | ||
| - Serial with the add/edit buttons to load the holdings editor. |
There was a problem hiding this comment.
Suggested change
| - Serial with the add/edit buttons to load the holdings editor. | |
| - Serial with the add/edit buttons to load the holding editor. |
RELEASE-NOTES.rst
Outdated
Comment on lines
59
to
60
| - Displays links to IdRef persons in the brief view and in the search | ||
| suggestions. |
There was a problem hiding this comment.
Is it really to IdRef persons? Not to MEF persons or just to persons?
There was a problem hiding this comment.
I understand now. Should we rather write the following?
Add IdRef persons in the person search (adapts search suggestions and person brief view)
RELEASE-NOTES.rst
Outdated
| Acquisition | ||
| ~~~~~~~~~~~ | ||
|
|
||
| - Begins to implement serials management with the creation of a manual |
There was a problem hiding this comment.
Suggested change
| - Begins to implement serials management with the creation of a manual | |
| - Begins to implement serial management with the creation of a manual |
RELEASE-NOTES.rst
Outdated
Comment on lines
116
to
117
| - Adds an ``holdings_type`` parameter to the holdings to | ||
| differentiate standard records (ie monograph), electronic records |
There was a problem hiding this comment.
Suggested change
| - Adds an ``holdings_type`` parameter to the holdings to | |
| differentiate standard records (ie monograph), electronic records | |
| - Adds a ``holdings_type`` parameter to the holdings to | |
| differentiate standard records (ie monographs), electronic records |
RELEASE-NOTES.rst
Outdated
| - Adds an ``holdings_type`` parameter to the holdings to | ||
| differentiate standard records (ie monograph), electronic records | ||
| or serials. | ||
| - Updates the holdings JSON schema to: |
There was a problem hiding this comment.
I never know but I think we write the genitive either with apostrophe or with 1st word in singular form... Maybe @MarionRERO knows?
Suggested change
| - Updates the holdings JSON schema to: | |
| - Updates the holding's JSON schema to: |
There was a problem hiding this comment.
The problem is that "holdings" stands for "holdings record", as I understand it. The LoC documentation do not use "holding" in the singular form. I still make the error, though. Maybe It should be "the JSON schema of the holdings records".
RELEASE-NOTES.rst
Outdated
| - Encode the publication pattern in the holdings records. | ||
|
|
||
| - Computes predicted issues preview based on the publication pattern | ||
| of a given holdings. |
There was a problem hiding this comment.
Suggested change
| of a given holdings. | |
| of a given holding. |
RELEASE-NOTES.rst
Outdated
Comment on lines
145
to
146
| - Adds in the fixtures the 10 publication patterns that are most used | ||
| in actual libraries of the RERO network. |
There was a problem hiding this comment.
Suggested change
| - Adds in the fixtures the 10 publication patterns that are most used | |
| in actual libraries of the RERO network. | |
| - Adds in the fixtures the 10 publication patterns that are currently most used | |
| in the RERO network. |
mmo
reviewed
May 5, 2020
RELEASE-NOTES.rst
Outdated
| ~~~~~~~~ | ||
|
|
||
| - Updates Invenio framework to version ``3.2.1``! | ||
| - Upgrades ``https-proxy-agent`` for security reason. |
RELEASE-NOTES.rst
Outdated
| using the web browser Chrome/Chromium wasn’t able to update the | ||
| pickup location of a request. | ||
| - `rero/rero-ils-ui#140 <https://github.com/rero/rero-ils-ui/issues/140>`__: | ||
| the library facet is missing in the professional interface. |
* Updates the version number (rero-ils/version.py). * Updates the RELEASE-NOTES.rst and the CHANGES.rst files. * Moves rero-ils-ui version to v0.1.2. Co-Authored-by: Igor Milhit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Igor Milhit [email protected]
Why are you opening this PR?
To publish the
v0.8.0release.How to test?
Check changed files.
Code review check list