Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enqueues notifications #951

Merged
merged 1 commit into from
May 8, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Apr 24, 2020

  • Enqueues notifications for asynchron processing.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

How to test?

  • run setup and see if the notifications sending is asynchrone (see worker log)

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@rerowep rerowep requested a review from BadrAly April 24, 2020 05:53
@rerowep rerowep self-assigned this Apr 24, 2020
@rerowep rerowep force-pushed the wep-#1449-asynchrone-notifications branch 6 times, most recently from c07b790 to 3b4aec1 Compare April 27, 2020 15:18
@rerowep rerowep requested review from zannkukai, jma and lauren-d April 27, 2020 19:12
@rerowep rerowep force-pushed the wep-#1449-asynchrone-notifications branch 10 times, most recently from 4362c40 to f71e482 Compare May 2, 2020 13:22
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notification: enqueue notifications

* Enqueues notifications for asynchronous processing.

Why this commit is needed?

@rerowep rerowep force-pushed the wep-#1449-asynchrone-notifications branch from f71e482 to ad97b54 Compare May 4, 2020 17:28
@rerowep rerowep requested a review from iGormilhit May 4, 2020 17:28
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Asynchron" still does not exist in English: asychronous.

@rerowep rerowep force-pushed the wep-#1449-asynchrone-notifications branch from ad97b54 to 68244ad Compare May 5, 2020 07:34
@rerowep rerowep requested a review from iGormilhit May 5, 2020 07:34
@rerowep rerowep force-pushed the wep-#1449-asynchrone-notifications branch from 68244ad to 3cc81e1 Compare May 5, 2020 20:19
@rerowep rerowep force-pushed the wep-#1449-asynchrone-notifications branch 4 times, most recently from 53f3fc3 to 898740c Compare May 7, 2020 07:28
* Enqueues notifications for asynchron processing.
This allows a more scalable and secure handling of notifications.
Now worker can handel the sending of notifications without blocking blocking the main process.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1449-asynchrone-notifications branch from 898740c to ca5086e Compare May 7, 2020 14:39
@rerowep rerowep merged commit 200e42c into rero:dev May 8, 2020
@rerowep rerowep deleted the wep-#1449-asynchrone-notifications branch May 8, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants