-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enqueues notifications #951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c07b790
to
3b4aec1
Compare
zannkukai
approved these changes
Apr 28, 2020
lauren-d
approved these changes
Apr 28, 2020
4362c40
to
f71e482
Compare
iGormilhit
suggested changes
May 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notification: enqueue notifications
* Enqueues notifications for asynchronous processing.
Why this commit is needed?
f71e482
to
ad97b54
Compare
iGormilhit
suggested changes
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Asynchron" still does not exist in English: asychronous.
ad97b54
to
68244ad
Compare
68244ad
to
3cc81e1
Compare
53f3fc3
to
898740c
Compare
* Enqueues notifications for asynchron processing. This allows a more scalable and secure handling of notifications. Now worker can handel the sending of notifications without blocking blocking the main process. Co-Authored-by: Peter Weber <[email protected]>
898740c
to
ca5086e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Peter Weber [email protected]
Why are you opening this PR?
How to test?
Code review check list