test: fix library opening timezone due date #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we will enter in GMT+2 in few days, a test failed as it compare wrong date (first in Zurich timezone and second in UTC one). We should compare dates in UTC only. * Compares date in UTC for opening hours of a given library Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
doo-#1381-test-timezone-due-date
branch
from
cf3cd4d to
66d7e8a
Compare
rerowep
reviewed
Mar 22, 2020
There was a problem hiding this comment.
Is it possible to write a script witch changes the date of the computer and running pipenv run pytest tests/api/test_loans_rest.py for every day of the year. Also running the same tests in a leap year to be sure we don't have problems with the date any more?
The test itself is ok now.
jma
approved these changes
Mar 23, 2020
It's a good idea! I will check today. |
BadrAly
approved these changes
Mar 23, 2020
reropag
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we will enter in GMT+2 in few days, a test failed as it compare wrong
date (first in Zurich timezone and second in UTC one).
We should compare dates in UTC only.
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
Because of https://tree.taiga.io/project/rero21-reroils/task/1381
How to test?
./run-tests.shCode review check list